WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 229924
Refactor Video,Audio,TextTrack and TrackLists to not depend on HTMLMediaElement
https://bugs.webkit.org/show_bug.cgi?id=229924
Summary
Refactor Video,Audio,TextTrack and TrackLists to not depend on HTMLMediaElement
Jer Noble
Reported
2021-09-05 12:41:23 PDT
Refactor Video,Audio,TextTrack and TrackLists to not depend on HTMLMediaElement
Attachments
Patch
(109.20 KB, patch)
2021-09-05 17:46 PDT
,
Jer Noble
no flags
Details
Formatted Diff
Diff
Patch
(106.78 KB, patch)
2021-09-07 14:47 PDT
,
Jer Noble
ews-feeder
: commit-queue-
Details
Formatted Diff
Diff
Patch
(106.88 KB, patch)
2021-09-07 15:01 PDT
,
Jer Noble
no flags
Details
Formatted Diff
Diff
Patch
(107.08 KB, patch)
2021-09-07 15:57 PDT
,
Jer Noble
no flags
Details
Formatted Diff
Diff
Patch
(107.25 KB, patch)
2021-09-07 20:20 PDT
,
Jer Noble
no flags
Details
Formatted Diff
Diff
Patch
(107.19 KB, patch)
2021-09-08 09:26 PDT
,
Jer Noble
no flags
Details
Formatted Diff
Diff
Patch
(107.35 KB, patch)
2021-09-08 11:22 PDT
,
Jer Noble
no flags
Details
Formatted Diff
Diff
Patch
(107.40 KB, patch)
2021-09-08 11:30 PDT
,
Jer Noble
no flags
Details
Formatted Diff
Diff
Show Obsolete
(7)
View All
Add attachment
proposed patch, testcase, etc.
Jer Noble
Comment 1
2021-09-05 17:46:40 PDT
Comment hidden (obsolete)
Created
attachment 437369
[details]
Patch
Jer Noble
Comment 2
2021-09-07 14:47:15 PDT
Comment hidden (obsolete)
Created
attachment 437557
[details]
Patch
Jer Noble
Comment 3
2021-09-07 15:01:28 PDT
Comment hidden (obsolete)
Created
attachment 437560
[details]
Patch
Jer Noble
Comment 4
2021-09-07 15:57:52 PDT
Comment hidden (obsolete)
Created
attachment 437567
[details]
Patch
Jer Noble
Comment 5
2021-09-07 20:20:21 PDT
Comment hidden (obsolete)
Created
attachment 437585
[details]
Patch
Jer Noble
Comment 6
2021-09-08 09:26:27 PDT
Comment hidden (obsolete)
Created
attachment 437635
[details]
Patch
Jer Noble
Comment 7
2021-09-08 11:22:53 PDT
Comment hidden (obsolete)
Created
attachment 437649
[details]
Patch
Jer Noble
Comment 8
2021-09-08 11:30:55 PDT
Created
attachment 437650
[details]
Patch
EWS
Comment 9
2021-09-09 09:49:59 PDT
Committed
r282220
(
241507@main
): <
https://commits.webkit.org/241507@main
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 437650
[details]
.
Radar WebKit Bug Importer
Comment 10
2021-09-09 09:51:18 PDT
<
rdar://problem/82929817
>
Ryosuke Niwa
Comment 11
2021-09-10 15:38:35 PDT
Comment on
attachment 437650
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=437650&action=review
> Source/WebCore/Modules/mediasource/SourceBuffer.cpp:638 > + m_videoTracks = VideoTrackList::create(scriptExecutionContext()); > + m_videoTracks->setOpaqueRootObserver(m_opaqueRootProvider);
Maybe we should cal this setOpaqueRootProvider? Or better yet, maybe the create function should take it as an argument.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug