Bug 22992 - Javascript console should not attempt to scroll to end of console if console is not visible
Summary: Javascript console should not attempt to scroll to end of console if console ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Alexander Pavlov (apavlov)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2008-12-25 02:17 PST by Oliver Hunt
Modified: 2010-02-25 14:15 PST (History)
5 users (show)

See Also:


Attachments
[PATCH] Proposed solution (1.88 KB, patch)
2010-02-25 08:21 PST, Alexander Pavlov (apavlov)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2008-12-25 02:17:23 PST
* SUMMARY
Whenever a message is sent to the console the web inspector attempts to scroll the appropriate portion of the console to be visible.  Unfortunately if the console is not visible, this is very heavy wait operation as it requires building the rendertree, calculating where it should scroll to, then throwing the rendertree away.

* STEPS TO REPRODUCE
1. use javascript along the lines of javascript:while(1) console.log("foo")

* RESULTS
Shark shows 94% of time being spent in style recalc.

<rdar://problem/6467200>
Comment 1 Alexander Pavlov (apavlov) 2010-02-25 08:14:27 PST
This scenario is also extremely slow when the console is visible. The scrollIntoView calls should be throttled.
Comment 2 Alexander Pavlov (apavlov) 2010-02-25 08:21:40 PST
Created attachment 49489 [details]
[PATCH] Proposed solution
Comment 3 WebKit Commit Bot 2010-02-25 14:14:57 PST
Comment on attachment 49489 [details]
[PATCH] Proposed solution

Clearing flags on attachment: 49489

Committed r55255: <http://trac.webkit.org/changeset/55255>
Comment 4 WebKit Commit Bot 2010-02-25 14:15:01 PST
All reviewed patches have been landed.  Closing bug.