Bug 229897 - Implement exp,log functions calc functions
Summary: Implement exp,log functions calc functions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nikos Mouchtaris
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-09-03 14:47 PDT by Nikos Mouchtaris
Modified: 2021-09-20 17:25 PDT (History)
11 users (show)

See Also:

Attachments
Patch (13.96 KB, patch)
2021-09-03 14:48 PDT, Nikos Mouchtaris 		no flags Details | Formatted Diff | Diff
Patch (20.91 KB, patch)
2021-09-14 17:02 PDT, Nikos Mouchtaris 		no flags Details | Formatted Diff | Diff
Patch (27.51 KB, patch)
2021-09-15 12:44 PDT, Nikos Mouchtaris 		simon.fraser: review+
Details | Formatted Diff | Diff
implement exp/log calc functions (28.02 KB, patch)
2021-09-16 14:10 PDT, Nikos Mouchtaris 		no flags Details | Formatted Diff | Diff
Exp/log functions (30.17 KB, patch)
2021-09-17 13:42 PDT, Nikos Mouchtaris 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
exp/log functions (30.16 KB, patch)
2021-09-20 14:54 PDT, Nikos Mouchtaris 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikos Mouchtaris 2021-09-03 14:47:36 PDT 
Implement exp,log functions calc functions
Comment 1 Nikos Mouchtaris 2021-09-03 14:48:53 PDT 
Created attachment 437316 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2021-09-07 13:46:39 PDT 
<rdar://problem/82837516>
Comment 3 Nikos Mouchtaris 2021-09-14 17:02:28 PDT 
Created attachment 438191 [details]
Patch
Comment 4 EWS Watchlist 2021-09-14 17:03:42 PDT 
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Comment 5 Nikos Mouchtaris 2021-09-15 12:44:48 PDT 
Created attachment 438280 [details]
Patch
Comment 6 Simon Fraser (smfr) 2021-09-15 16:53:00 PDT 
Comment on attachment 438280 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438280&action=review

> Source/WebCore/ChangeLog:7
> +        Reviewed by NOBODY (OOPS!).
> +

You should write some words here about the change.

> Source/WebCore/css/calc/CSSCalcOperationNode.cpp:-441
> -        return;

Is this removal significant? The changelog does not mention it.
Comment 7 Simon Fraser (smfr) 2021-09-15 16:59:55 PDT 
Comment on attachment 438280 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438280&action=review

> Source/WebCore/css/calc/CSSCalcOperationNode.cpp:478
> +            

Remove this blank line.
Comment 8 Nikos Mouchtaris 2021-09-16 14:10:40 PDT 
Created attachment 438400 [details]
implement exp/log calc functions
Comment 9 Nikos Mouchtaris 2021-09-17 13:42:20 PDT 
Created attachment 438508 [details]
Exp/log functions
Comment 10 EWS 2021-09-20 14:48:09 PDT 
ChangeLog entry in LayoutTests/imported/w3c/ChangeLog contains OOPS!.
Comment 11 Nikos Mouchtaris 2021-09-20 14:54:41 PDT 
Created attachment 438735 [details]
exp/log functions
Comment 12 EWS 2021-09-20 17:24:58 PDT 
Committed r282795 (241929@main): <https://commits.webkit.org/241929@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 438735 [details].