Bug 229894 - Fix for debug mode on MSVC after r281998
Summary: Fix for debug mode on MSVC after r281998
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-09-03 14:03 PDT by Stephan Szabo
Modified: 2021-09-03 16:41 PDT (History)
1 user (show)

See Also:


Attachments
Patch (1.66 KB, patch)
2021-09-03 14:42 PDT, Stephan Szabo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stephan Szabo 2021-09-03 14:03:54 PDT
Unfortunately my previous fix for having ENABLE(SERVICE_WORKER) off in debug seems to have failed on wincairo complaining about uses of #if inside the ASSERT() macro.
Comment 1 Stephan Szabo 2021-09-03 14:42:52 PDT
Created attachment 437313 [details]
Patch
Comment 2 EWS 2021-09-03 16:40:50 PDT
Committed r282036 (241337@main): <https://commits.webkit.org/241337@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 437313 [details].
Comment 3 Radar WebKit Bug Importer 2021-09-03 16:41:21 PDT
<rdar://problem/82744760>