RESOLVED FIXED 229887
Simplify PCM::Client interface 
https://bugs.webkit.org/show_bug.cgi?id=229887
Summary Simplify PCM::Client interface
Alex Christensen
Reported 2021-09-03 12:42:12 PDT
Simplify PCM::Client interface
Attachments
Patch (15.83 KB, patch)
2021-09-03 12:57 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2021-09-03 12:57:45 PDT
Created attachment 437303 [details] Patch
Kate Cheney
Comment 2 2021-09-03 15:13:34 PDT
Comment on attachment 437303 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=437303&action=review r=me > Source/WebKit/NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementNetworkLoader.cpp:50 > + request.setHTTPBody(WebCore::FormData::create(jsonPayload->toJSONString().utf8())); You dropped a .data() here, was that intentional?
Alex Christensen
Comment 3 2021-09-03 15:14:02 PDT
Yes, I think that removed an unnecessary CString copy.
EWS
Comment 4 2021-09-03 15:28:01 PDT
Committed r282031 (241335@main): <https://commits.webkit.org/241335@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 437303 [details].
Radar WebKit Bug Importer
Comment 5 2021-09-03 15:29:15 PDT
<rdar://problem/82741931>
John Wilander
Comment 6 2021-09-03 15:38:06 PDT
View in context: https://bugs.webkit.org/attachment.cgi?id=437303&action=review LGTM. See comment. > Source/WebKit/NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementNetworkLoader.cpp:41 > +static NetworkLoadParameters generateNetworkLoadParameters(URL&& url, RefPtr<JSON::Object>&& jsonPayload, PrivateClickMeasurement::PcmDataCarried pcmDataCarried) This function does the exact same thing as the three deleted ones above, right? Except we lost the UNLIKELY(isDebugModeEnabled) which I don't know how much it gave us.
Alex Christensen
Comment 7 2021-09-03 16:15:32 PDT
Right.
Note You need to log in before you can comment on or make changes to this bug.