Bug 22987 - Regression: LayoutTests/editing/execCommand/5763082.html crashes
Summary: Regression: LayoutTests/editing/execCommand/5763082.html crashes
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2008-12-24 15:18 PST by Dmitry Titov
Modified: 2008-12-26 00:47 PST (History)
1 user (show)

See Also:

Proposed patch (1.49 KB, patch)
2008-12-24 15:37 PST, Dmitry Titov
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Titov 2008-12-24 15:18:37 PST
This test started crashing after r39456 because the function CompositeEditCommand::mergeIdenticalElements now has PassRefPtr parameters and passes them into more then one other function, losing their value along the way. The fix is to store parameters in local RefPtr variables and use those.
Comment 1 Dmitry Titov 2008-12-24 15:37:23 PST
Created attachment 26242 [details]
Proposed patch
Comment 2 Darin Adler 2008-12-25 10:04:11 PST
Comment on attachment 26242 [details]
Proposed patch


Thanks for fixing the regression I caused!
Comment 3 Alexey Proskuryakov 2008-12-26 00:47:38 PST
Committed revision 39475.