Bug 229853 - [JSC] Fix WebKitAdditions directory traversal in offlineasm part 2
Summary: [JSC] Fix WebKitAdditions directory traversal in offlineasm part 2
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-09-03 01:10 PDT by Yusuke Suzuki
Modified: 2021-09-03 11:15 PDT (History)
7 users (show)

See Also:

Attachments
Patch (12.21 KB, patch)
2021-09-03 01:17 PDT, Yusuke Suzuki 		mark.lam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2021-09-03 01:10:27 PDT 
[JSC] Fix WebKitAdditions directory traversal in offlineasm part 2
Comment 1 Yusuke Suzuki 2021-09-03 01:17:43 PDT 
Created attachment 437251 [details]
Patch
Comment 2 Mark Lam 2021-09-03 04:04:47 PDT 
Comment on attachment 437251 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=437251&action=review

r=me

> Source/JavaScriptCore/offlineasm/asm.rb:343
> +    opts.on("--webkit-additions-path=PATH", "Flag to use deployment location.") do |path|

Can you change “Flag to use deployment location” to “WebKitAdditions path”?

> Source/JavaScriptCore/offlineasm/generate_offset_extractor.rb:52
> +    opts.on("--webkit-additions-path=PATH", "Flag to use deployment location.") do |path|

Ditto.

> Source/JavaScriptCore/offlineasm/generate_settings_extractor.rb:49
> +    opts.on("--webkit-additions-path=PATH", "Flag to use deployment location.") do |path|

Ditto.
Comment 3 Ryan Haddad 2021-09-03 10:47:25 PDT 
rdar://82728326
Comment 4 Yusuke Suzuki 2021-09-03 11:15:46 PDT 
Committed r282009 (241316@main): <https://commits.webkit.org/241316@main>