Bug 22985 - RenderLayer cached clip rects are sometimes incorrect
Summary: RenderLayer cached clip rects are sometimes incorrect
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-12-24 13:59 PST by Simon Fraser (smfr)
Modified: 2009-01-05 21:38 PST (History)
1 user (show)

See Also:

Attachments
Patch, changelog (4.32 KB, patch)
2008-12-24 14:11 PST, Simon Fraser (smfr) 		hyatt: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2008-12-24 13:59:59 PST 
I added an assertion to test that cached clip rects are used with the same rootLayer as they were computed with. This caught a couple of problems, which I'll submit a patch for.
Comment 1 Simon Fraser (smfr) 2008-12-24 14:11:22 PST 
Created attachment 26241 [details]
Patch, changelog

I wasn't able to easily create a LayoutTest to exercise these fixes, but the assertion provides testing.
Comment 2 Simon Fraser (smfr) 2008-12-24 14:13:22 PST 
Also, did you know that clipRects are cleared on every mouse move, because MouseRelatedEvent::receivedTarget() calls layer->updateLayerPosition() before setting event->layerX and event->layerY (which are totally bogus anyway, bug 21868).
Comment 3 Dave Hyatt 2009-01-05 14:23:48 PST 
Comment on attachment 26241 [details]
Patch, changelog

r=me.  If you can make a test case please do so.  If not, ok.
Comment 4 Simon Fraser (smfr) 2009-01-05 21:38:00 PST 
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/rendering/RenderLayer.cpp
	M	WebCore/rendering/RenderLayer.h
	M	WebCore/rendering/RenderTreeAsText.cpp
Committed r39640