Bug 229845 - Fix for debug mode with ENABLE_SERVICE_WORKER=OFF after r281706
Summary: Fix for debug mode with ENABLE_SERVICE_WORKER=OFF after r281706
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Stephan Szabo
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-09-02 18:52 PDT by Stephan Szabo
Modified: 2021-09-03 09:15 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.61 KB, patch)
2021-09-02 18:57 PDT, Stephan Szabo 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stephan Szabo 2021-09-02 18:52:41 PDT 
There's an ASSERT that used m_serviceWorkerFetchTask outside of an #if ENABLE(SERVICE_WORKER) block.
Comment 1 Stephan Szabo 2021-09-02 18:57:50 PDT 
Created attachment 437231 [details]
Patch

I'm not sure stylistically how we want to handle cases like this, so just put the only sometimes enabled bit on its own inside the if and made the assert go across lines.
Comment 2 EWS 2021-09-03 09:14:37 PDT 
Committed r281998 (241305@main): <https://commits.webkit.org/241305@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 437231 [details].
Comment 3 Radar WebKit Bug Importer 2021-09-03 09:15:26 PDT 
<rdar://problem/82726075>