WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
229845
Fix for debug mode with ENABLE_SERVICE_WORKER=OFF after
r281706
https://bugs.webkit.org/show_bug.cgi?id=229845
Summary
Fix for debug mode with ENABLE_SERVICE_WORKER=OFF after r281706
Stephan Szabo
Reported
2021-09-02 18:52:41 PDT
There's an ASSERT that used m_serviceWorkerFetchTask outside of an #if ENABLE(SERVICE_WORKER) block.
Attachments
Patch
(1.61 KB, patch)
2021-09-02 18:57 PDT
,
Stephan Szabo
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Stephan Szabo
Comment 1
2021-09-02 18:57:50 PDT
Created
attachment 437231
[details]
Patch I'm not sure stylistically how we want to handle cases like this, so just put the only sometimes enabled bit on its own inside the if and made the assert go across lines.
EWS
Comment 2
2021-09-03 09:14:37 PDT
Committed
r281998
(
241305@main
): <
https://commits.webkit.org/241305@main
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 437231
[details]
.
Radar WebKit Bug Importer
Comment 3
2021-09-03 09:15:26 PDT
<
rdar://problem/82726075
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug