Bug 229828 - Gracefully recover from WebAuthnProcess crashes
Summary: Gracefully recover from WebAuthnProcess crashes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-09-02 13:48 PDT by Alex Christensen
Modified: 2021-09-02 16:26 PDT (History)
4 users (show)

See Also:


Attachments
Patch (8.10 KB, patch)
2021-09-02 13:51 PDT, Alex Christensen
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (7.93 KB, patch)
2021-09-02 14:04 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2021-09-02 13:48:55 PDT
Gracefully recover from WebAuthnProcess crashes
Comment 1 Alex Christensen 2021-09-02 13:51:06 PDT
Created attachment 437190 [details]
Patch
Comment 2 Chris Dumez 2021-09-02 13:57:09 PDT
Comment on attachment 437190 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=437190&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKProcessPool.mm:205
> ++ (void)_terminateWebAuthnProcess

I think we should omit this and just call kill() in the API test.
Comment 3 Alex Christensen 2021-09-02 14:04:38 PDT
Created attachment 437191 [details]
Patch
Comment 4 Chris Dumez 2021-09-02 14:08:09 PDT
Comment on attachment 437191 [details]
Patch

r=me assuming the bots are happy.
Comment 5 EWS 2021-09-02 16:25:25 PDT
Committed r281965 (241272@main): <https://commits.webkit.org/241272@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 437191 [details].
Comment 6 Radar WebKit Bug Importer 2021-09-02 16:26:20 PDT
<rdar://problem/82698252>