Bug 229813 – Buffer large media XHRs in the NetworkProcess to reduce IPC overhead

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Jer Noble]

Buffer large media XHRs in the NetworkProcess to reduce IPC overhead

[Jer Noble]

<rdar://82406803>

[Jer Noble]

Created attachment 437180 [details]
Patch

[Peng Liu]

Comment on attachment 437180 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=437180&action=review

> Source/WebKit/WebProcess/Network/WebLoaderStrategy.h:94
> +    static constexpr Seconds mediaMaximumBufferingTime { 50_s };

50_s?

[Alex Christensen]

Comment on attachment 437180 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=437180&action=review

> Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:652
> +        && m_response.expectedContentLength() > static_cast<long long>(1 * MB)

I would put this check before isMediaMIMEType because it's a cheap integer comparison that's likely to fail.

> Source/WebKit/NetworkProcess/NetworkResourceLoader.h:213
> +    NetworkResourceLoadParameters m_parameters;

I think it would be better to mark maximumBufferingTime as mutable rather than all the parameters as non-const.

[Jer Noble]

(In reply to Peng Liu from comment #3)
> Comment on attachment 437180 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=437180&action=review
> 
> > Source/WebKit/WebProcess/Network/WebLoaderStrategy.h:94
> > +    static constexpr Seconds mediaMaximumBufferingTime { 50_s };
> 
> 50_s?

OMG. Nice catch.

[Jer Noble]

Created attachment 437182 [details]
Patch for landing

[Jer Noble]

Created attachment 437198 [details]
Patch for landing

[EWS]

Committed r282003 (241310@main): <https://commits.webkit.org/241310@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 437198 [details].