Bug 229797 - [css-highlight-api] Use AbstractRange instead of StaticRange in Highlight IDL
Summary: [css-highlight-api] Use AbstractRange instead of StaticRange in Highlight IDL
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Keywords: InRadar, WebExposed
Depends on:
Blocks: 204903
  Show dependency treegraph
Reported: 2021-09-02 02:24 PDT by Manuel Rego Casasnovas
Modified: 2021-09-22 19:13 PDT (History)
7 users (show)

See Also:

WIP patch (7.20 KB, patch)
2021-09-22 08:59 PDT, Chris Dumez
ews-feeder: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Manuel Rego Casasnovas 2021-09-02 02:24:53 PDT
The IDL is using StaticRange: https://github.com/WebKit/WebKit/blob/main/Source/WebCore/Modules/highlight/Highlight.idl

AbstractRange was implemented in https://trac.webkit.org/changeset/268648/webkit

So we could now update the Highlight API to accept AbstractRange and match the spec: https://drafts.csswg.org/css-highlight-api-1/#highlight

Otherwise most of the WPT tests that use Range() will fail in WebKit: https://wpt.fyi/results/css/css-highlight-api
Comment 1 Radar WebKit Bug Importer 2021-09-09 02:25:16 PDT
Comment 2 Chris Dumez 2021-09-22 08:59:10 PDT
Created attachment 438953 [details]
WIP patch
Comment 3 Chris Dumez 2021-09-22 14:27:16 PDT
Looks like we haven't imported the css/css-highlight-api WPT tests.