Bug 229794 - Revert X86_64 JIT probe code for non DARWIN ports.
Summary: Revert X86_64 JIT probe code for non DARWIN ports.
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-09-02 01:27 PDT by Mark Lam
Modified: 2021-09-02 07:24 PDT (History)
7 users (show)

See Also:

Attachments
proposed patch. (4.84 KB, patch)
2021-09-02 01:34 PDT, Mark Lam 		mark.lam: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2021-09-02 01:27:16 PDT 
This is to address https://bugs.webkit.org/show_bug.cgi?id=229618#c10.
Comment 1 Mark Lam 2021-09-02 01:34:41 PDT 
Created attachment 437125 [details]
proposed patch.
Comment 2 Diego Pino 2021-09-02 01:44:13 PDT 
Thanks for the patch! I'm going to give it a try on Ubuntu 18.04.
Comment 3 Yusuke Suzuki 2021-09-02 01:47:42 PDT 
I tried landing a speculative change. https://github.com/WebKit/WebKit/commit/ed75252f8730bd3006fe76456f427e9b307c43ba

@Diago
Can you change the buildbot to generate more error messages from ld?
Comment 4 Diego Pino 2021-09-02 03:12:31 PDT 
I tested Mark's patch on Ubuntu 18.04 and it built fine.

After that, I reverted the patch and tested the speculative main with the speculative fix. It built too.

I've triggered a clean build in the bot and I've also increased the verbosity of ld.gold.
Comment 5 Diego Pino 2021-09-02 03:25:15 PDT 
Link to the Ubuntu 18.04 build including the speculative fix https://build.webkit.org/#/builders/71/builds/224
Comment 6 Diego Pino 2021-09-02 03:40:58 PDT 
There's currently an issue in the bot (it's failing on "jhbuild" step). I stopped the bot temporarily and I'm building manually.
Comment 7 Diego Pino 2021-09-02 07:13:32 PDT 
I confirm Yusuke's patch fixes compilation in Ubuntu 18.04, so this patch is not actually needed. Thank you Mark anyway.