Bug 229793 - [JSC] Fix invalid exception checks in Temporal classes
Summary: [JSC] Fix invalid exception checks in Temporal classes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ross Kirsling
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-09-01 23:46 PDT by Ross Kirsling
Modified: 2021-09-02 01:55 PDT (History)
8 users (show)

See Also:


Attachments
Patch (7.08 KB, patch)
2021-09-01 23:47 PDT, Ross Kirsling
no flags Details | Formatted Diff | Diff
Patch for landing (7.03 KB, patch)
2021-09-02 00:53 PDT, Ross Kirsling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ross Kirsling 2021-09-01 23:46:34 PDT
[JSC] Fix invalid exception checks in Temporal classes
Comment 1 Ross Kirsling 2021-09-01 23:47:21 PDT
Created attachment 437115 [details]
Patch
Comment 2 Yusuke Suzuki 2021-09-02 00:45:55 PDT
Comment on attachment 437115 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=437115&action=review

r=me with comments.

> Source/JavaScriptCore/runtime/TemporalDurationPrototype.cpp:132
> +    RETURN_IF_EXCEPTION(scope, encodedJSValue());

In new code, we are using RETURN_IF_EXCEPTION(scope, { });

> Source/JavaScriptCore/runtime/TemporalDurationPrototype.cpp:171
> +    RETURN_IF_EXCEPTION(scope, encodedJSValue());

Ditto.

> Source/JavaScriptCore/runtime/TemporalDurationPrototype.cpp:186
> +    RETURN_IF_EXCEPTION(scope, encodedJSValue());

Ditto.

> Source/JavaScriptCore/runtime/TemporalDurationPrototype.cpp:205
> +    RETURN_IF_EXCEPTION(scope, encodedJSValue());

Ditto.
Comment 3 Ross Kirsling 2021-09-02 00:53:51 PDT
Created attachment 437120 [details]
Patch for landing
Comment 4 EWS 2021-09-02 01:52:16 PDT
Committed r281912 (241224@main): <https://commits.webkit.org/241224@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 437120 [details].
Comment 5 Radar WebKit Bug Importer 2021-09-02 01:55:08 PDT
<rdar://problem/82665434>