Bug 229789 - Introduce PCM::Client for PrivateClickMeasurementManager
Summary: Introduce PCM::Client for PrivateClickMeasurementManager
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-09-01 18:45 PDT by Alex Christensen
Modified: 2021-09-02 11:58 PDT (History)
2 users (show)

See Also:

Attachments
Patch (32.91 KB, patch)
2021-09-01 18:46 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (32.97 KB, patch)
2021-09-01 19:58 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (32.97 KB, patch)
2021-09-02 11:21 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2021-09-01 18:45:28 PDT 
Introduce PCM::Client for PrivateClickMeasurementManager
Comment 1 Alex Christensen 2021-09-01 18:46:07 PDT 
Created attachment 437103 [details]
Patch
Comment 2 Alex Christensen 2021-09-01 19:58:21 PDT 
Created attachment 437110 [details]
Patch
Comment 3 Kate Cheney 2021-09-02 11:13:03 PDT 
Comment on attachment 437110 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=437110&action=review

> Source/WebKit/NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementClientImpl.cpp:42
> +    if (!m_networkSession)

We could use if (!featureEnabled()) here instead

> Source/WebKit/NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementClientImpl.cpp:50
> +    if (!m_networkSession)

ditto
Comment 4 Alex Christensen 2021-09-02 11:21:54 PDT 
Created attachment 437171 [details]
Patch
Comment 5 EWS 2021-09-02 11:57:41 PDT 
Committed r281944 (241252@main): <https://commits.webkit.org/241252@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 437171 [details].
Comment 6 Radar WebKit Bug Importer 2021-09-02 11:58:27 PDT 
<rdar://problem/82686814>