Bug 229779 – Rewrite long press and drag tests to be more robust.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Megan Gardner]

Rewrite long press and drag tests to be more robust.

[Megan Gardner]

Created attachment 437084 [details]
Patch

[Wenson Hsieh]

Comment on attachment 437084 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=437084&action=review

> Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:407
> +            NSNumber *touchX = touch[HIDEventXKey] == [NSNull null] ? 0 : touch[HIDEventXKey];

Nit - `0` should be `nil`

> Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:408
> +            NSNumber *touchY = touch[HIDEventYKey] == [NSNull null] ? 0 : touch[HIDEventYKey];

Ditto.

> LayoutTests/fast/events/touch/ios/long-press-on-editable-content-then-drag-right-to-change-selected-text.html:16
> +        

Nit - stray whitespace.

> LayoutTests/fast/events/touch/ios/long-press-on-editable-content-then-drag-right-to-change-selected-text.html:73
> +    

Ditto.

> LayoutTests/fast/events/touch/ios/long-press-on-editable-content-then-drag-up-to-change-selected-text.html:16
> +        

Ditto.

> LayoutTests/fast/events/touch/ios/long-press-on-editable-content-then-drag-up-to-change-selected-text.html:70
> +    

Ditto.

> LayoutTests/resources/ui-helper.js:822
> +    static  midPointOfRect(rect) {

Nit - it looks like there are two spaces between `static` and `midPointOfRect`.

I'd also write this like `return { x: rect.left + (rect.width / 2), y: rect.top + (rect.height / 2) };`

[Wenson Hsieh]

rdar://40917203

[Wenson Hsieh]

> > Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:407
> > +            NSNumber *touchX = touch[HIDEventXKey] == [NSNull null] ? 0 : touch[HIDEventXKey];
> 
> Nit - `0` should be `nil`
> 

(..at least, either `nil` or `@0`).

[Megan Gardner]

Created attachment 437526 [details]
Patch for landing

[EWS]

Committed r282096 (241395@main): <https://commits.webkit.org/241395@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 437526 [details].