Bug 229741 - Non-unified build partial fixes, late late August 2021
Summary: Non-unified build partial fixes, late late August 2021
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Lauro Moura
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-08-31 14:45 PDT by Lauro Moura
Modified: 2021-08-31 19:26 PDT (History)
23 users (show)

See Also:

Attachments
Patch (16.71 KB, patch)
2021-08-31 14:47 PDT, Lauro Moura 		no flags Details | Formatted Diff | Diff
Rebased patch (15.66 KB, patch)
2021-08-31 15:01 PDT, Lauro Moura 		no flags Details | Formatted Diff | Diff
Link issue build log (20.84 KB, text/x-log)
2021-08-31 15:04 PDT, Lauro Moura 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lauro Moura 2021-08-31 14:45:55 PDT 
Non-unified build partial fixes, late late August 2021
Comment 1 Lauro Moura 2021-08-31 14:47:23 PDT 
Created attachment 436948 [details]
Patch
Comment 2 Lauro Moura 2021-08-31 14:50:21 PDT 
Comment on attachment 436948 [details]
Patch

Waiting for EWS before CQ+'ing.
Comment 3 Lauro Moura 2021-08-31 14:52:11 PDT 
Comment on attachment 436948 [details]
Patch

Needs rebase.
Comment 4 Lauro Moura 2021-08-31 15:01:01 PDT 
Created attachment 436950 [details]
Rebased patch
Comment 5 Lauro Moura 2021-08-31 15:01:46 PDT 
Comment on attachment 436950 [details]
Rebased patch

Note to self: Remember "--review" in Unreviewed patches...
Comment 6 Lauro Moura 2021-08-31 15:04:00 PDT 
Created attachment 436951 [details]
Link issue build log

There is still a strange link error about some WebCore symbols missing from WebCoreTestSupport.a when linking lib/libTestRunnerInjectedBundle.so:

For example (full error attached):

lib/libWebCoreTestSupport.a(lib/../Source/WebCore/CMakeFiles/WebCoreTestSupport.dir/testing/Internals.cpp.o):Internals.cpp:function WebCore::createRecorderMockSource(WebCore::MediaStreamPrivate&, WebCore::MediaRecorderPrivateOptions const&): error: undefined reference to 'WebCore::MediaRecorderPrivateMock::MediaRecorderPrivateMock(WebCore::MediaStreamPrivate&)'
lib/libWebCoreTestSupport.a(lib/../Source/WebCore/CMakeFiles/WebCoreTestSupport.dir/testing/Internals.cpp.o):Internals.cpp:function WebCore::InspectorStubFrontend::closeWindow(): error: undefined reference to 'WebCore::InspectorFrontendClientLocal::inspectedPage() const'
lib/libWebCoreTestSupport.a(lib/../Source/WebCore/CMakeFiles/WebCoreTestSupport.dir/testing/Internals.cpp.o):Internals.cpp:function WebCore::InspectorStubFrontend::InspectorStubFrontend(WebCore::Page&, WTF::RefPtr<WebCore::DOMWindow, WTF::RawPtrTraits<WebCore::DOMWindow>, WTF::DefaultRefDerefTraits<WebCore::DOMWindow> >&&): error: undefined reference to 'vtable for WebCore::InspectorFrontendClientLocal::Settings'
/usr/lib/gcc/x86_64-unknown-linux-gnu/10.2.0/../../../../x86_64-unknown-linux-gnu/bin/ld.gold: the vtable symbol may be undefined because the class is missing its key function
lib/libWebCoreTestSupport.a(lib/../Source/WebCore/CMakeFiles/WebCoreTestSupport.dir/testing/Internals.cpp.o):Internals.cpp:function WebCore::InspectorStubFrontend::InspectorStubFrontend(WebCore::Page&, WTF::RefPtr<WebCore::DOMWindow, WTF::RawPtrTraits<WebCore::DOMWindow>, WTF::DefaultRefDerefTraits<WebCore::DOMWindow> >&&): error: undefined reference to 'WebCore::InspectorFrontendClientLocal::InspectorFrontendClientLocal(WebCore::InspectorController*, WebCore::Page*, std::unique_ptr<WebCore::InspectorFrontendClientLocal::Settings, std::default_delete<WebCore::InspectorFrontendClientLocal::Settings> >)'
lib/libWebCoreTestSupport.a(lib/../Source/WebCore/CMakeFiles/WebCoreTestSupport.dir/testing/Internals.cpp.o):Internals.cpp:function WebCore::Internals::initializeMockMediaSource(): error: undefined reference to 'WebCore::MockMediaPlayerMediaSource::registerMediaEngine(void (*)(std::unique_ptr<WebCore::MediaPlayerFactory, std::default_delete<WebCore::MediaPlayerFactory> >&&))'
lib/libWebCoreTestSupport.a(lib/../Source/WebCore/CMakeFiles/WebCoreTestSupport.dir/testing/Internals.cpp.o):Internals.cpp:function WebCore::Internals::parseDoViCodecParameters(WTF::StringView): error: undefined reference to 'WebCore::parseDoViCodecParameters(WTF::StringView)'
Comment 7 EWS 2021-08-31 19:25:39 PDT 
Committed r281837 (241170@main): <https://commits.webkit.org/241170@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 436950 [details].
Comment 8 Radar WebKit Bug Importer 2021-08-31 19:26:26 PDT 
<rdar://problem/82607704>