Bug 229739 - [git-webkit] Support callbacks as main arguments
Summary: [git-webkit] Support callbacks as main arguments
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-08-31 14:36 PDT by Jonathan Bedard
Modified: 2021-09-07 16:02 PDT (History)
3 users (show)

See Also:

Attachments
Patch (3.74 KB, patch)
2021-08-31 15:06 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch for landing (5.11 KB, patch)
2021-09-07 14:21 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2021-08-31 14:36:51 PDT 
git-webkit can be applied to other repositories. The main function of git-webkit has a few arguments that projects can use to customize behavior. Often, the value of those arguments should change based on the repository git-webkit is operating on.
Comment 1 Radar WebKit Bug Importer 2021-08-31 14:39:00 PDT 
<rdar://problem/82597266>
Comment 2 Jonathan Bedard 2021-08-31 15:06:31 PDT 
Created attachment 436952 [details]
Patch
Comment 3 Jonathan Bedard 2021-08-31 16:20:30 PDT 
Pull-request: https://github.com/WebKit/WebKit/pull/7
Comment 4 dewei_zhu 2021-09-07 13:54:53 PDT 
Comment on attachment 436952 [details]
Patch

r=me
Comment 5 Jonathan Bedard 2021-09-07 14:21:31 PDT 
Created attachment 437555 [details]
Patch for landing
Comment 6 EWS 2021-09-07 15:05:02 PDT 
Committed r282108 (241406@main): <https://commits.webkit.org/241406@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 437555 [details].
Comment 7 Jonathan Bedard 2021-09-07 16:02:50 PDT 
Committed r282113 (241410@main): <https://commits.webkit.org/241410@main>