Bug 229724 - [RunBindingsTests] Invoke with Python 3
Summary: [RunBindingsTests] Invoke with Python 3
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kevin Neal
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-08-31 11:55 PDT by Kevin Neal
Modified: 2021-09-01 10:34 PDT (History)
6 users (show)

See Also:


Attachments
Patch (4.10 KB, patch)
2021-08-31 12:00 PDT, Kevin Neal
no flags Details | Formatted Diff | Diff
Patch (5.30 KB, patch)
2021-08-31 13:20 PDT, Kevin Neal
no flags Details | Formatted Diff | Diff
Testing Patch (5.32 KB, patch)
2021-08-31 17:20 PDT, Kevin Neal
no flags Details | Formatted Diff | Diff
Testing patch (5.32 KB, patch)
2021-09-01 08:30 PDT, Kevin Neal
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Neal 2021-08-31 11:55:25 PDT
RunBindingsTests should be invoked with Python 3.
Comment 1 Kevin Neal 2021-08-31 12:00:56 PDT
Created attachment 436922 [details]
Patch
Comment 2 Kevin Neal 2021-08-31 13:20:14 PDT
Created attachment 436933 [details]
Patch
Comment 3 Radar WebKit Bug Importer 2021-08-31 14:44:19 PDT
<rdar://problem/82597513>
Comment 4 Kevin Neal 2021-08-31 17:20:00 PDT
Created attachment 436970 [details]
Testing Patch
Comment 5 Darin Adler 2021-08-31 18:41:53 PDT
Comment on attachment 436970 [details]
Testing Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=436970&action=review

> Tools/Scripts/run-bindings-tests:2
> -# Copyright (C) 2010 Google Inc.  All rights reserved.
> +# Copyright (C) 2021 Apple Inc.  All rights reserved.

Why are we removing the Google copyright? That doesn’t make sense; was it only on here by accident? If we made modifications, we could add the Apple copyright, but not replace the Google one.
Comment 6 Jonathan Bedard 2021-09-01 07:54:58 PDT
(In reply to Darin Adler from comment #5)
> Comment on attachment 436970 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=436970&action=review
> 
> > Tools/Scripts/run-bindings-tests:2
> > -# Copyright (C) 2010 Google Inc.  All rights reserved.
> > +# Copyright (C) 2021 Apple Inc.  All rights reserved.
> 
> Why are we removing the Google copyright? That doesn’t make sense; was it
> only on here by accident? If we made modifications, we could add the Apple
> copyright, but not replace the Google one.

This patch is just to verify everything works with Python 3 in infrastructure, and is not to be landed.

The problem with testing a change like this is that buildbot can't test changes to it's own code outside unit tests. So although the patch you r+ed is passing all tests, run-bindings-tests wasn't actually invoked with Python 3. The work around for this is to create a dummy testing patch which basically invokes the script with Python 3, even if it was invoked with Python 2. In this case, Kevin entirely replaced the old run-bindings-tests with a new file that invokes run-bindings-tests-python3 with Python 3, and moved the old contents of run-bindings-tests to run-bindings-tests-python3
Comment 7 Kevin Neal 2021-09-01 08:30:13 PDT
Created attachment 437033 [details]
Testing patch
Comment 8 EWS 2021-09-01 10:16:57 PDT
Committed r281856 (241187@main): <https://commits.webkit.org/241187@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 436933 [details].
Comment 9 Aakash Jain 2021-09-01 10:34:26 PDT
Also tested in https://ews-build.webkit-uat.org/#/builders/7/builds/78