WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
229721
Loads after session restore marked app initiated in Safari
https://bugs.webkit.org/show_bug.cgi?id=229721
Summary
Loads after session restore marked app initiated in Safari
Kate Cheney
Reported
2021-08-31 10:28:30 PDT
Loads after session restore marked app initiated in Safari
Attachments
Patch
(16.77 KB, patch)
2021-08-31 10:35 PDT
,
Kate Cheney
no flags
Details
Formatted Diff
Diff
Patch
(16.74 KB, patch)
2021-08-31 11:05 PDT
,
Kate Cheney
no flags
Details
Formatted Diff
Diff
Patch for landing
(16.83 KB, patch)
2021-08-31 12:35 PDT
,
Kate Cheney
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Kate Cheney
Comment 1
2021-08-31 10:35:40 PDT
Created
attachment 436906
[details]
Patch
Kate Cheney
Comment 2
2021-08-31 11:05:32 PDT
Created
attachment 436915
[details]
Patch
Brent Fulgham
Comment 3
2021-08-31 11:21:09 PDT
Comment on
attachment 436915
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=436915&action=review
r=me
> Source/WebKit/WebProcess/WebPage/WebPage.h:1592 > + void goToBackForwardItem(uint64_t navigationID, const WebCore::BackForwardItemIdentifier&, WebCore::FrameLoadType, WebCore::ShouldTreatAsContinuingLoad, std::optional<WebsitePoliciesData>&&, bool);
The bool should have a name here, because it's not clear from the context what it means.
Kate Cheney
Comment 4
2021-08-31 12:35:04 PDT
Created
attachment 436928
[details]
Patch for landing
EWS
Comment 5
2021-08-31 13:26:55 PDT
Committed
r281817
(
241153@main
): <
https://commits.webkit.org/241153@main
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 436928
[details]
.
Radar WebKit Bug Importer
Comment 6
2021-08-31 13:27:18 PDT
<
rdar://problem/82593785
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug