Bug 229712 - [contributors.json] Replace class=bot with status=bot
Summary: [contributors.json] Replace class=bot with status=bot
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-08-31 08:09 PDT by Jonathan Bedard
Modified: 2021-08-31 09:11 PDT (History)
4 users (show)

See Also:

Attachments
Patch (4.86 KB, patch)
2021-08-31 08:16 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch (4.85 KB, patch)
2021-08-31 08:35 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2021-08-31 08:09:52 PDT 
Separating class from bot makes generalizing contributors.json difficult. Given that none of our bots declare themselves to be committers or reviewers, we should just replace instances of class=bot with status=bot so we don't have an extra variable.
Comment 1 Radar WebKit Bug Importer 2021-08-31 08:12:48 PDT 
<rdar://problem/82579767>
Comment 2 Jonathan Bedard 2021-08-31 08:16:41 PDT 
Created attachment 436885 [details]
Patch
Comment 3 Aakash Jain 2021-08-31 08:23:38 PDT 
Comment on attachment 436885 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=436885&action=review

> Tools/Scripts/webkitpy/common/config/committers.py:252
> +            elif data.get('status') == 'bot':

data.get('status') => status
Comment 4 Jonathan Bedard 2021-08-31 08:35:22 PDT 
Created attachment 436886 [details]
Patch
Comment 5 EWS 2021-08-31 09:11:44 PDT 
Committed r281806 (241142@main): <https://commits.webkit.org/241142@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 436886 [details].