Bug 22971 - REGRESSION: Uploading empty files via <input type="file"/> broken
Summary: REGRESSION: Uploading empty files via <input type="file"/> broken
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Nikolas Zimmermann
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-12-22 17:01 PST by Nikolas Zimmermann
Modified: 2008-12-22 17:52 PST (History)
1 user (show)

See Also:

Attachments
Initial patch (5.39 KB, patch)
2008-12-22 17:22 PST, Nikolas Zimmermann 		no flags Details | Formatted Diff | Diff
Updated patch (4.66 KB, patch)
2008-12-22 17:23 PST, Nikolas Zimmermann 		staikos: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikolas Zimmermann 2008-12-22 17:01:23 PST 
The regressions appears in r39430, when I refactored the HTMLFormElement code. Fixable by moving one line of code. I'm creating a layout test for this, then going to upload a patch.
Comment 1 Nikolas Zimmermann 2008-12-22 17:22:01 PST 
Created attachment 26220 [details]
Initial patch
Comment 2 Nikolas Zimmermann 2008-12-22 17:23:21 PST 
Created attachment 26221 [details]
Updated patch

Remove some stray content in the patch.
Comment 3 George Staikos 2008-12-22 17:25:47 PST 
Comment on attachment 26221 [details]
Updated patch

Please add some comments to explain this rather crazy issue...  The code is highly confusing.  Otherwise r+
Comment 4 Nikolas Zimmermann 2008-12-22 17:30:09 PST 
Explained with a comment. Landed in r39445.
Comment 5 Darin Adler 2008-12-22 17:36:51 PST 
The comment is great, but I wouldn't have mentioned the specific layout test in it. Thanks for fixing this so quickly.
Comment 6 Nikolas Zimmermann 2008-12-22 17:44:17 PST 
(In reply to comment #5)
> The comment is great, but I wouldn't have mentioned the specific layout test in
> it. Thanks for fixing this so quickly.

You're welcome. Shall I remove the comment regarding the layout tests? rs=you on this?
Comment 7 Darin Adler 2008-12-22 17:52:02 PST 
(In reply to comment #6)
> Shall I remove the comment regarding the layout tests? rs=you
> on this?

Sure.