Bug 229708 - [SOUP] Assertion in startObservingCookieChanges()
Summary: [SOUP] Assertion in startObservingCookieChanges()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-08-31 04:24 PDT by Carlos Garcia Campos
Modified: 2021-08-31 07:20 PDT (History)
7 users (show)

See Also:

Attachments
Patch (7.58 KB, patch)
2021-08-31 04:27 PDT, Carlos Garcia Campos 		pnormand: review+
Details | Formatted Diff | Diff
Patch for landing (7.53 KB, patch)
2021-08-31 04:40 PDT, Carlos Garcia Campos 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2021-08-31 04:24:12 PDT 
For some reason we don't implement startObservingCookieChanges() and stopObservingCookieChanges() for soup, and we set the observer callback from the network session constructor/destructor.
Comment 1 Carlos Garcia Campos 2021-08-31 04:27:17 PDT 
Created attachment 436873 [details]
Patch
Comment 2 Carlos Garcia Campos 2021-08-31 04:40:17 PDT 
Created attachment 436874 [details]
Patch for landing
Comment 3 EWS 2021-08-31 07:19:37 PDT 
Committed r281801 (241138@main): <https://commits.webkit.org/241138@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 436874 [details].
Comment 4 Radar WebKit Bug Importer 2021-08-31 07:20:20 PDT 
<rdar://problem/82578143>