RESOLVED FIXED Bug 229707
[WASM-Function-References] Add support for (ref.null heaptype) 
https://bugs.webkit.org/show_bug.cgi?id=229707
Summary [WASM-Function-References] Add support for (ref.null heaptype)
Dmitry
Reported 2021-08-31 04:23:54 PDT
Function references proposal introduces new form of ref.null instruction that can take <heaptype> immediate. To fully support the proposal we need to add new form of ref.null.
Attachments
Patch (15.93 KB, patch)
2021-10-05 02:22 PDT, Dmitry 		no flags
DetailsFormatted DiffDiff
Patch (18.27 KB, patch)
2021-10-05 02:29 PDT, Dmitry 		no flags
DetailsFormatted DiffDiff
Patch (18.58 KB, patch)
2021-10-28 00:26 PDT, Dmitry 		no flags
DetailsFormatted DiffDiff
Patch (18.49 KB, patch)
2021-10-29 01:35 PDT, Dmitry 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-09-07 04:24:15 PDT
<rdar://problem/82816107>
Dmitry
Comment 2 2021-10-05 02:22:48 PDT
Created attachment 440184 [details] Patch
Dmitry
Comment 3 2021-10-05 02:29:33 PDT
Created attachment 440187 [details] Patch
Dmitry
Comment 4 2021-10-28 00:26:15 PDT
Created attachment 442681 [details] Patch
Yusuke Suzuki
Comment 5 2021-10-28 15:33:36 PDT
Comment on attachment 442681 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=442681&action=review r=me with nit. > Source/JavaScriptCore/wasm/WasmAirIRGenerator.cpp:3456 > + append(Move, Arg::bigImm(JSValue::encode(jsNull())), tmp1); > + append(Compare64, Arg::relCond(MacroAssembler::Equal), calleeFunction, tmp1, tmp2); > + emitCheck([&] { > + return Inst(BranchTest32, nullptr, Arg::resCond(MacroAssembler::NonZero), tmp2, tmp2); > + }, [=] (CCallHelpers& jit, const B3::StackmapGenerationParams&) { > + this->emitThrowException(jit, ExceptionType::NullReference); > + }); We should use Branch64 instead of Compare64 and BranchTest32.
Dmitry
Comment 6 2021-10-29 01:35:17 PDT
Created attachment 442794 [details] Patch
Yusuke Suzuki
Comment 7 2021-10-29 17:35:07 PDT
Comment on attachment 442794 [details] Patch r=me
EWS
Comment 8 2021-10-29 17:46:34 PDT
Committed r285065 (243707@main): <https://commits.webkit.org/243707@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 442794 [details].
Note You need to log in before you can comment on or make changes to this bug.