WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
229705
Add support for CSSKeywordValue in CSS Typed OM
https://bugs.webkit.org/show_bug.cgi?id=229705
Summary
Add support for CSSKeywordValue in CSS Typed OM
Qiaosong Zhou
Reported
2021-08-31 03:09:32 PDT
Add support for CSSKeywordValue in CSS Typed OM
Attachments
Patch
(15.83 KB, patch)
2021-08-31 03:10 PDT
,
Qiaosong Zhou
ews-feeder
: commit-queue-
Details
Formatted Diff
Diff
Patch
(16.34 KB, patch)
2021-08-31 03:33 PDT
,
Qiaosong Zhou
no flags
Details
Formatted Diff
Diff
Patch
(254.92 KB, patch)
2021-09-01 03:54 PDT
,
Qiaosong Zhou
no flags
Details
Formatted Diff
Diff
Patch
(254.86 KB, patch)
2021-09-01 03:57 PDT
,
Qiaosong Zhou
no flags
Details
Formatted Diff
Diff
Patch
(254.39 KB, patch)
2021-09-01 04:10 PDT
,
Qiaosong Zhou
no flags
Details
Formatted Diff
Diff
Patch
(254.39 KB, patch)
2021-09-01 15:55 PDT
,
Qiaosong Zhou
no flags
Details
Formatted Diff
Diff
Show Obsolete
(5)
View All
Add attachment
proposed patch, testcase, etc.
Qiaosong Zhou
Comment 1
2021-08-31 03:10:00 PDT
Created
attachment 436866
[details]
Patch
Qiaosong Zhou
Comment 2
2021-08-31 03:33:51 PDT
Created
attachment 436869
[details]
Patch
Alex Christensen
Comment 3
2021-08-31 11:37:53 PDT
Comment on
attachment 436869
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=436869&action=review
This is a wonderful patch.
> Source/WebCore/css/typedom/CSSKeywordValue.cpp:2 > + * Copyright (C) 2019 Apple Inc. All rights reserved.
2021
> Source/WebCore/css/typedom/CSSKeywordValue.cpp:44 > + if (value.isNull() || value.isEmpty())
value.isEmpty returns true if value is null, so only one check is needed.
> Source/WebCore/css/typedom/CSSKeywordValue.cpp:52 > + if (value.isNull() || value.isEmpty())
ditto
> Source/WebCore/css/typedom/CSSKeywordValue.h:2 > + * Copyright (C) 2018 Apple Inc. All rights reserved.
2021
> Source/WebCore/css/typedom/CSSKeywordValue.h:30 > +#include "CSSKeywordValue.h"
This shouldn't include itself.
> Source/WebCore/css/typedom/CSSKeywordValue.h:32 > +#include <wtf/RefCounted.h>
This doesn't look needed.
> Source/WebCore/css/typedom/CSSKeywordValue.h:44 > + String& value() { return m_value; }
const String& value() const
> Source/WebCore/css/typedom/CSSKeywordValue.idl:2 > +* Copyright (C) 2018 Apple Inc. All rights reserved.
2021
Qiaosong Zhou
Comment 4
2021-09-01 03:54:53 PDT
Created
attachment 437010
[details]
Patch
Qiaosong Zhou
Comment 5
2021-09-01 03:57:07 PDT
Created
attachment 437011
[details]
Patch
Qiaosong Zhou
Comment 6
2021-09-01 04:10:58 PDT
Created
attachment 437012
[details]
Patch
Alex Christensen
Comment 7
2021-09-01 09:31:33 PDT
Comment on
attachment 437012
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=437012&action=review
And three copyright years need updating, but otherwise this looks ready to go.
> Source/WebCore/css/typedom/CSSKeywordValue.h:43 > + const String& value() { return m_value; }
This needs a const between () and { to indicate that calling the function doesn't mutate the object. The first const indicates that you can't mutate the returned reference.
Qiaosong Zhou
Comment 8
2021-09-01 15:55:16 PDT
Created
attachment 437075
[details]
Patch
EWS
Comment 9
2021-09-02 12:39:12 PDT
Committed
r281947
(
241255@main
): <
https://commits.webkit.org/241255@main
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 437075
[details]
.
Radar WebKit Bug Importer
Comment 10
2021-09-02 12:40:33 PDT
<
rdar://problem/82688747
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug