Bug 229656 - [ iOS ] Run tests in fast/forms/ios by default in EWS
Summary: [ iOS ] Run tests in fast/forms/ios by default in EWS
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
Keywords: InRadar
Depends on:
Reported: 2021-08-29 12:30 PDT by Wenson Hsieh
Modified: 2022-08-15 15:37 PDT (History)
7 users (show)

See Also:

For EWS (11.12 KB, patch)
2021-08-29 12:37 PDT, Wenson Hsieh
no flags Details | Formatted Diff | Diff
For EWS (11.18 KB, patch)
2021-08-29 13:52 PDT, Wenson Hsieh
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2021-08-29 12:30:53 PDT
Comment 1 Wenson Hsieh 2021-08-29 12:37:20 PDT Comment hidden (obsolete)
Comment 2 Wenson Hsieh 2021-08-29 13:52:14 PDT
Created attachment 436748 [details]
Comment 3 Wenson Hsieh 2021-08-29 17:49:31 PDT
Comment on attachment 436748 [details]

Thanks for the review!
Comment 4 EWS 2021-08-29 17:53:10 PDT
Committed r281749 (241091@main): <https://commits.webkit.org/241091@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 436748 [details].
Comment 5 Radar WebKit Bug Importer 2021-08-29 17:54:22 PDT
Comment 6 ayumi_kojima 2021-09-14 15:16:35 PDT
fast/forms/ios/ipad/open-picker-using-keyboard.html is timing out on iPad: https://results.webkit.org/?suite=layout-tests&test=fast%2Fforms%2Fios%2Fipad%2Fopen-picker-using-keyboard.html

It seems to be because of the expectations for fast/forms/iOS/ipad is set to pass in ipad in https://trac.webkit.org/changeset/281815/webkit

Added the test expectations as pass/timeout in iPad directory so that it doesn't timeout on iPad: https://trac.webkit.org/changeset/282414/webkit
Comment 7 Hercules Hjalmarsson 2022-07-28 15:53:35 PDT
After gardening https://commits.webkit.org/252752@main.

iPad test is now flakily timing out. Reverting change to iPad in order to resolve flaky timeout.
Comment 8 EWS 2022-08-15 15:37:17 PDT
Test gardening commit 253444@main (4c0133ab31ce): <https://commits.webkit.org/253444@main>

Reviewed commits have been landed. Closing PR #3329 and removing active labels.