Bug 229643 – CSSFontFaceSet.clear() should not clear CSS-connected members

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Myles C. Maxfield]

CSSFontFaceSet.clear() should not clear CSS-connected members

[Myles C. Maxfield]

Created attachment 436709 [details]
Patch

[Myles C. Maxfield]

Created attachment 436710 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 436710 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=436710&action=review

> Source/WebCore/ChangeLog:11
> +        Test: fast/text/FontFaceSet-clear-css-connected.html

Can this be a WPT?

[Myles C. Maxfield]

Comment on attachment 436710 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=436710&action=review

>> Source/WebCore/ChangeLog:11
>> +        Test: fast/text/FontFaceSet-clear-css-connected.html
> 
> Can this be a WPT?

https://github.com/web-platform-tests/wpt/pull/30254

[Darin Adler]

Comment on attachment 436710 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=436710&action=review

> Source/WebCore/css/FontFaceSet.cpp:137
> +        m_backing->remove(m_backing.get()[facesPartitionIndex]);

Is this high-performance enough? Might be worth thinking that through.

[Myles C. Maxfield]

Comment on attachment 436710 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=436710&action=review

>> Source/WebCore/css/FontFaceSet.cpp:137
>> +        m_backing->remove(m_backing.get()[facesPartitionIndex]);
> 
> Is this high-performance enough? Might be worth thinking that through.

I've never actually seen any website ever call this function, so I think sharing code and guaranteeing that all the necessary work in remove() runs is probably more valuable than squeezing more performance out of this function.

[Myles C. Maxfield]

Comment on attachment 436710 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=436710&action=review

>>> Source/WebCore/css/FontFaceSet.cpp:137
>>> +        m_backing->remove(m_backing.get()[facesPartitionIndex]);
>> 
>> Is this high-performance enough? Might be worth thinking that through.
> 
> I've never actually seen any website ever call this function, so I think sharing code and guaranteeing that all the necessary work in remove() runs is probably more valuable than squeezing more performance out of this function.

I guess I can at least iterate backwards, though.

[Myles C. Maxfield]

Committed r281842 (241175@main): <https://commits.webkit.org/241175@main>

[Radar WebKit Bug Importer]

<rdar://problem/82617907>