Bug 22964 - Build failure - QtWebKit with MinGW toolchain
Summary: Build failure - QtWebKit with MinGW toolchain
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-12-22 10:33 PST by Laszlo Gombos
Modified: 2008-12-31 09:13 PST (History)
1 user (show)

See Also:

Attachments
Patch - fix (1.10 KB, patch)
2008-12-22 10:35 PST, Laszlo Gombos 		zecke: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Laszlo Gombos 2008-12-22 10:33:03 PST 
WebCore/platform/graphics/qt/SimpleFontDataQt.cpp fails to compile; because the signature of the containsCharacter() function in the base class (SimpleFontData.h) does not match the the function signature in the derived class.
Comment 1 Laszlo Gombos 2008-12-22 10:35:39 PST 
Created attachment 26205 [details]
Patch - fix

Fix !
Comment 2 Laszlo Gombos 2008-12-22 11:02:26 PST 
(In reply to comment #1)
> Created an attachment (id=26205) [review]
> Patch - fix
> 
> Fix !
> 

The proposed fix reverses part of the change (1 line) that was made as part of Changeset 39207 - http://trac.webkit.org/changeset/39207/trunk/WebCore/platform/graphics/qt/SimpleFontDataQt.cpp

Laszlo
Comment 3 Holger Freyther 2008-12-23 09:58:52 PST 
Comment on attachment 26205 [details]
Patch - fix


> @@ -1,3 +1,14 @@
> +2008-12-22  Laszlo Gombos  <laszlo.1.gombos@gmail.com>

Any reason to not use the Nokia email address?
Comment 4 Laszlo Gombos 2008-12-23 10:26:22 PST 
(In reply to comment #3)
> (From update of attachment 26205 [details] [review])
> 
> > @@ -1,3 +1,14 @@
> > +2008-12-22  Laszlo Gombos  <laszlo.1.gombos@gmail.com>
> 
> Any reason to not use the Nokia email address?
> 

Sorry, mistyped my e-mail. It should be laszlo.1.gombos@nokia.com

Laszlo
Comment 5 Holger Freyther 2008-12-31 09:13:19 PST 
Landed in r39530.