Bug 229639 - @font-face rules accessed over file: urls to a file which does not exist are not visible to document.fonts
Summary: @font-face rules accessed over file: urls to a file which does not exist are ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks: 229850
  Show dependency treegraph
 
Reported: 2021-08-27 22:07 PDT by Myles C. Maxfield
Modified: 2021-09-03 13:19 PDT (History)
10 users (show)

See Also:


Attachments
Patch (3.91 KB, patch)
2021-08-27 22:10 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
Patch (3.84 KB, patch)
2021-08-31 02:50 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
Patch (5.67 KB, patch)
2021-09-01 02:59 PDT, Myles C. Maxfield
zalan: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2021-08-27 22:07:59 PDT
@font-face blocks accessed over file: urls to a file which does not exist are not visible to document.fonts
Comment 1 Myles C. Maxfield 2021-08-27 22:10:34 PDT
Created attachment 436704 [details]
Patch
Comment 2 Simon Fraser (smfr) 2021-08-30 15:59:08 PDT
Comment on attachment 436704 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=436704&action=review

I don't know enough about whether pages should access local files to review this.

> Source/WebCore/ChangeLog:3
> +        @font-face blocks accessed over file: urls to a file which does not exist are not visible to document.fonts

Can you rename this from "blocks" to "rules"?

> LayoutTests/fast/text/font-file-failed.html:7
> +    src: url("ThisIsNotARealFile.otf") format("opentype");

Should this be an explicit file: url so the test works if run from http?
Comment 3 Myles C. Maxfield 2021-08-31 02:50:11 PDT
Created attachment 436861 [details]
Patch
Comment 4 Myles C. Maxfield 2021-09-01 02:59:41 PDT
Created attachment 437008 [details]
Patch
Comment 5 Myles C. Maxfield 2021-09-03 13:18:47 PDT
Committed r282017 (241322@main): <https://commits.webkit.org/241322@main>
Comment 6 Radar WebKit Bug Importer 2021-09-03 13:19:14 PDT
<rdar://problem/82736270>