Bug 229636 - MessageArgumentDescriptions.cpp generator incorrectly strips std::optional<> from argument types
Summary: MessageArgumentDescriptions.cpp generator incorrectly strips std::optional<> ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Cameron McCormack (:heycam)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-08-27 17:28 PDT by Cameron McCormack (:heycam)
Modified: 2021-08-27 23:04 PDT (History)
2 users (show)

See Also:


Attachments
Patch (2.71 KB, patch)
2021-08-27 17:33 PDT, Cameron McCormack (:heycam)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Cameron McCormack (:heycam) 2021-08-27 17:28:31 PDT
The substring indexes need updating.
Comment 1 Radar WebKit Bug Importer 2021-08-27 17:28:48 PDT
<rdar://problem/82461615>
Comment 2 Cameron McCormack (:heycam) 2021-08-27 17:33:40 PDT
Created attachment 436697 [details]
Patch
Comment 3 Darin Adler 2021-08-27 17:43:34 PDT
Comment on attachment 436697 [details]
Patch

Did I break this when moving from WTF::Optional to std::optional? If so, I wonder how because they are both the same length!
Comment 4 Cameron McCormack (:heycam) 2021-08-27 17:51:04 PDT
I guess previously the WTF:: prefix must not have been used in the messages.in files?
Comment 5 EWS 2021-08-27 23:04:44 PDT
Committed r281732 (241074@main): <https://commits.webkit.org/241074@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 436697 [details].