WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
229634
ews might mark build as successful if JSC tests fail to run
https://bugs.webkit.org/show_bug.cgi?id=229634
Summary
ews might mark build as successful if JSC tests fail to run
Aakash Jain
Reported
2021-08-27 16:34:39 PDT
EWS might mark build as successful in certain conditions if JSC tests fail to run (either due to some infrastructure issue or the patch breaking the tests so that they can't generate json results). For e.g. in
https://ews-build.webkit.org/#/builders/1/builds/44335
tests failed to run properly with the patch. However the build was marked successful. Similarly, in
https://ews-build.webkit.org/#/builders/46/builds/15944
tests were hanging (and were killed by buildbot after timeout), however the build was marked successful. Similar to
Bug 215944
for layout-tests.
Attachments
Patch
(7.70 KB, patch)
2021-08-30 03:36 PDT
,
Aakash Jain
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Aakash Jain
Comment 1
2021-08-30 03:36:13 PDT
Created
attachment 436762
[details]
Patch
EWS
Comment 2
2021-08-30 09:02:21 PDT
Committed
r281761
(
241102@main
): <
https://commits.webkit.org/241102@main
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 436762
[details]
.
Radar WebKit Bug Importer
Comment 3
2021-08-30 09:03:18 PDT
<
rdar://problem/82530520
>
Aakash Jain
Comment 4
2021-08-30 09:16:12 PDT
Restarted buildbot to pick up this change.
Aakash Jain
Comment 5
2021-09-03 06:20:04 PDT
Seems to be working fine. e.g.:
https://ews-build.webkit.org/#/builders/45/builds/6934
https://ews-build.webkit.org/#/builders/45/builds/6936
Aakash Jain
Comment 6
2021-09-10 08:27:33 PDT
***
Bug 219543
has been marked as a duplicate of this bug. ***
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug