Bug 229624 – Define ENABLE_CONTENT_CHANGE_OBSERVER for IOS_FAMILY and use it to wrap content observation code

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Simon Fraser (smfr)]

Define ENABLE_CONTENT_CHANGE_OBSERVER for IOS_FAMILY and use it to wrap content observation code

[Simon Fraser (smfr)]

Created attachment 436659 [details]
Patch

[EWS]

/Volumes/Data/worker/Commit-Queue/build/Source/WTF/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

[Simon Fraser (smfr)]

https://trac.webkit.org/changeset/281728/webkit

[Radar WebKit Bug Importer]

<rdar://problem/82461575>

[Darin Adler]

Comment on attachment 436659 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=436659&action=review

> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:355
>      auto& frame = m_page->focusController().focusedOrMainFrame();
> +#if ENABLE(CONTENT_CHANGE_OBSERVER)

Why did we leave this line above out of the #if?

[Simon Fraser (smfr)]

(In reply to Darin Adler from comment #5)
> Comment on attachment 436659 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=436659&action=review
> 
> > Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:355
> >      auto& frame = m_page->focusController().focusedOrMainFrame();
> > +#if ENABLE(CONTENT_CHANGE_OBSERVER)
> 
> Why did we leave this line above out of the #if?

That was a mistake. I saw focusController() and assumed it had side effects. Will fix.

[Simon Fraser (smfr)]

https://trac.webkit.org/changeset/281729/webkit