Bug 229624 - Define ENABLE_CONTENT_CHANGE_OBSERVER for IOS_FAMILY and use it to wrap content observation code
Summary: Define ENABLE_CONTENT_CHANGE_OBSERVER for IOS_FAMILY and use it to wrap conte...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-08-27 12:51 PDT by Simon Fraser (smfr)
Modified: 2021-08-27 17:57 PDT (History)
14 users (show)

See Also:

Attachments
Patch (18.70 KB, patch)
2021-08-27 12:52 PDT, Simon Fraser (smfr) 		zalan: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2021-08-27 12:51:53 PDT 
Define ENABLE_CONTENT_CHANGE_OBSERVER for IOS_FAMILY and use it to wrap content observation code
Comment 1 Simon Fraser (smfr) 2021-08-27 12:52:32 PDT 
Created attachment 436659 [details]
Patch
Comment 2 EWS 2021-08-27 16:40:43 PDT 
/Volumes/Data/worker/Commit-Queue/build/Source/WTF/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).
Comment 3 Simon Fraser (smfr) 2021-08-27 17:26:19 PDT 
https://trac.webkit.org/changeset/281728/webkit
Comment 4 Radar WebKit Bug Importer 2021-08-27 17:27:31 PDT 
<rdar://problem/82461575>
Comment 5 Darin Adler 2021-08-27 17:32:26 PDT 
Comment on attachment 436659 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=436659&action=review

> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:355
>      auto& frame = m_page->focusController().focusedOrMainFrame();
> +#if ENABLE(CONTENT_CHANGE_OBSERVER)

Why did we leave this line above out of the #if?
Comment 6 Simon Fraser (smfr) 2021-08-27 17:53:55 PDT 
(In reply to Darin Adler from comment #5)
> Comment on attachment 436659 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=436659&action=review
> 
> > Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:355
> >      auto& frame = m_page->focusController().focusedOrMainFrame();
> > +#if ENABLE(CONTENT_CHANGE_OBSERVER)
> 
> Why did we leave this line above out of the #if?

That was a mistake. I saw focusController() and assumed it had side effects. Will fix.
Comment 7 Simon Fraser (smfr) 2021-08-27 17:57:53 PDT 
https://trac.webkit.org/changeset/281729/webkit