Rename enums in CSSUnitType to CamelCase and remove CSS_ prefix. Most renames follow the format CSSUnitType::CSS_XXX_YYY => CSSUnitType::XxxYyy except for: * If there exists a method CSSPrimitiveValue::IsXXXX(), then it's renamed to CssUnitType::XXXX instead. For example, CSS_VW is renamed to ViewportPercentageWidth because of CSSPrimitiveValue::IsViewportPercentageWidth() * CSS_S is renamed to Second Feel free to comment if you think an enum should be renamed to something else.
Created attachment 436657 [details] Patch
Created attachment 436675 [details] Patch
Comment on attachment 436675 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=436675&action=review > Source/WebCore/css/CSSUnits.h:64 > + DotsPerInch = 31, > + DotsPerCentimeter = 32, We use Cm and In above so these should be DotsPerCm and DotsPerIn
(In reply to Simon Fraser (smfr) from comment #3) > Comment on attachment 436675 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=436675&action=review > > > Source/WebCore/css/CSSUnits.h:64 > > + DotsPerInch = 31, > > + DotsPerCentimeter = 32, > > We use Cm and In above so these should be DotsPerCm and DotsPerIn Or we could change Cm => Centimeter and In => Inch, let me know your preference.
I'm putting on hold before https://bugs.webkit.org/show_bug.cgi?id=229672 and https://bugs.webkit.org/show_bug.cgi?id=204276 is resolved.
<rdar://problem/82734077>
It seems that r+ patch didn't landed and this change is also not implemented. Example: https://github.com/WebKit/WebKit/blob/387077670b14ff83b0f1ea2c1f65be35ad962ad0/Source/WebCore/animation/CSSPropertyAnimation.cpp#L472 Do we need this? Thanks!