Bug 229620 – [GTK] Simplify run-gtk-tests handling of the a11y service

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Patrick Griffis]

[GTK] Simplify run-gtk-tests handling of the a11y service

[Patrick Griffis]

Created attachment 436648 [details]
Patch

[Patrick Griffis]

Created attachment 436650 [details]
Patch

[Patrick Griffis]

Created attachment 436653 [details]
Patch

[Michael Catanzaro]

Comment on attachment 436653 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=436653&action=review

> Tools/Scripts/run-gtk-tests:56
> +            sys.stderr.write("Failed to talk to the accessibility service {}\n".format(e))

Let's add a colon: "Failed to talk to the accessibility service: {}\n"

Also, can you check to ensure passing the error directly works? It will really print a nice error string and not some object ID? There is no e.message property that needs to be used instead?

[Patrick Griffis]

(In reply to Michael Catanzaro from comment #4)
> Also, can you check to ensure passing the error directly works? It will
> really print a nice error string and not some object ID? There is no
> e.message property that needs to be used instead?

It's verbose but I think thats mostly helpful:

    g-dbus-error-quark: GDBus.Error:org.freedesktop.DBus.Error.UnknownMethod: No such interface “org.foo.bar” on object at path /org/foo/bar (19)

[Patrick Griffis]

Created attachment 436660 [details]
Patch

[Carlos Garcia Campos]

Failed to talk to the accessibility service: Cannot autolaunch D-Bus without X11 $DISPLAY

That's what we are getting in EWS now.

[EWS]

Committed r281733 (241075@main): <https://commits.webkit.org/241075@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 436660 [details].