Bug 229620 - [GTK] Simplify run-gtk-tests handling of the a11y service
Summary: [GTK] Simplify run-gtk-tests handling of the a11y service
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Patrick Griffis
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-08-27 11:44 PDT by Patrick Griffis
Modified: 2021-08-27 23:53 PDT (History)
3 users (show)

See Also:


Attachments
Patch (5.77 KB, patch)
2021-08-27 11:44 PDT, Patrick Griffis
no flags Details | Formatted Diff | Diff
Patch (5.79 KB, patch)
2021-08-27 11:46 PDT, Patrick Griffis
no flags Details | Formatted Diff | Diff
Patch (5.95 KB, patch)
2021-08-27 12:01 PDT, Patrick Griffis
no flags Details | Formatted Diff | Diff
Patch (5.96 KB, patch)
2021-08-27 13:02 PDT, Patrick Griffis
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Griffis 2021-08-27 11:44:24 PDT
[GTK] Simplify run-gtk-tests handling of the a11y service
Comment 1 Patrick Griffis 2021-08-27 11:44:36 PDT
Created attachment 436648 [details]
Patch
Comment 2 Patrick Griffis 2021-08-27 11:46:45 PDT
Created attachment 436650 [details]
Patch
Comment 3 Patrick Griffis 2021-08-27 12:01:17 PDT
Created attachment 436653 [details]
Patch
Comment 4 Michael Catanzaro 2021-08-27 12:39:13 PDT
Comment on attachment 436653 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=436653&action=review

> Tools/Scripts/run-gtk-tests:56
> +            sys.stderr.write("Failed to talk to the accessibility service {}\n".format(e))

Let's add a colon: "Failed to talk to the accessibility service: {}\n"

Also, can you check to ensure passing the error directly works? It will really print a nice error string and not some object ID? There is no e.message property that needs to be used instead?
Comment 5 Patrick Griffis 2021-08-27 12:54:03 PDT
(In reply to Michael Catanzaro from comment #4)
> Also, can you check to ensure passing the error directly works? It will
> really print a nice error string and not some object ID? There is no
> e.message property that needs to be used instead?

It's verbose but I think thats mostly helpful:

    g-dbus-error-quark: GDBus.Error:org.freedesktop.DBus.Error.UnknownMethod: No such interface “org.foo.bar” on object at path /org/foo/bar (19)
Comment 6 Patrick Griffis 2021-08-27 13:02:06 PDT
Created attachment 436660 [details]
Patch
Comment 7 Carlos Garcia Campos 2021-08-27 23:40:29 PDT
Failed to talk to the accessibility service: Cannot autolaunch D-Bus without X11 $DISPLAY

That's what we are getting in EWS now.
Comment 8 EWS 2021-08-27 23:53:25 PDT
Committed r281733 (241075@main): <https://commits.webkit.org/241075@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 436660 [details].