Bug 22961 - Add WML <fieldset> element support.
Summary: Add WML <fieldset> element support.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: XML (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Nikolas Zimmermann
URL:
Keywords:
Depends on:
Blocks: 20393
  Show dependency tree / graph
 
Reported: 2008-12-22 07:27 PST by Nikolas Zimmermann
Modified: 2008-12-22 08:00 PST (History)
0 users

See Also:

Attachments
Initial patch (26.09 KB, patch)
2008-12-22 07:30 PST, Nikolas Zimmermann 		staikos: review+
Details | Formatted Diff | Diff
Layout test results (2.67 KB, patch)
2008-12-22 07:30 PST, Nikolas Zimmermann 		ap: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikolas Zimmermann 2008-12-22 07:27:46 PST 
WML <fieldset> element should be supported.
Comment 1 Nikolas Zimmermann 2008-12-22 07:30:32 PST 
Created attachment 26202 [details]
Initial patch
Comment 2 Nikolas Zimmermann 2008-12-22 07:30:50 PST 
Created attachment 26203 [details]
Layout test results
Comment 3 George Staikos 2008-12-22 07:33:49 PST 
Comment on attachment 26202 [details]
Initial patch

Only part I wonder about is that by changing the argument to Node* on the RenderFieldset constructor, someone might accidentally drop an unexpected type in there one day.  I don't think that's a reason for r- though.
Comment 4 Alexey Proskuryakov 2008-12-22 07:52:54 PST 
Comment on attachment 26203 [details]
Layout test results

r=me
Comment 5 Nikolas Zimmermann 2008-12-22 07:53:55 PST 
Alexey proposed to rename WMLDummyLegendElement to WMLInsertedLegendElement. Going to take care of this, before landing. Thanks for the quick review, guys.
Comment 6 Nikolas Zimmermann 2008-12-22 07:58:22 PST 
(In reply to comment #3)
> (From update of attachment 26202 [details] [review])
> Only part I wonder about is that by changing the argument to Node* on the
> RenderFieldset constructor, someone might accidentally drop an unexpected type
> in there one day.  I don't think that's a reason for r- though.
It's a bit weird that RenderFieldset actually took a HTMLForm*Element - this is contrary to the other RenderObject-derived classes, that all take Node*.

There are no casts to HTMLForm*Element, so it's just safe.
Comment 7 Nikolas Zimmermann 2008-12-22 08:00:59 PST 
Landed in r39436.