Bug 229607 - [GTK][WPE] Add ICU 63.1 to JHBuild minimal dependencies
Summary: [GTK][WPE] Add ICU 63.1 to JHBuild minimal dependencies
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Diego Pino
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-08-27 06:25 PDT by Diego Pino
Modified: 2021-08-29 22:02 PDT (History)
2 users (show)

See Also:


Attachments
Patch (3.39 KB, patch)
2021-08-27 06:26 PDT, Diego Pino
no flags Details | Formatted Diff | Diff
Patch (3.44 KB, patch)
2021-08-27 16:59 PDT, Diego Pino
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Pino 2021-08-27 06:25:49 PDT
[GTK][WPE] Add ICU 63.1 to JHBuild minimal dependencies
Comment 1 Diego Pino 2021-08-27 06:26:26 PDT
Created attachment 436620 [details]
Patch
Comment 2 Diego Pino 2021-08-27 06:33:40 PDT
r281375 introduced a function available only in ICU 61. Ubuntu 18.04 uses ICU systems libraries, which is version 60. Thus, compilation of WebKitGTK and WPE in Ubuntu 18.04 has been failing since then.

After discussing this with other WebKitGTK/WPE maintainers we think the best solution is to add ICU v63.1 to the list of minimal dependencies.
Comment 3 Carlos Alberto Lopez Perez 2021-08-27 06:53:14 PDT
Comment on attachment 436620 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=436620&action=review

> Tools/jhbuild/jhbuild-minimal.modules:96
> +  <autotools id="icu"
> +             autogen-sh="./source/configure"
> +             autogenargs="--disable-samples --enable-weak-threads">
> +    <branch module="icu4c-63_1-src.tgz" version="63.1" checkoutdir="icu"
> +            repo="webkitgtk-jhbuild-mirror"
> +            hash="sha256:05c490b69454fce5860b7e8e2821231674af0a11d7ef2febea9a32512998cb9d">
> +      <patch file="icudata-stdlibs.patch" strip="1"/>
> +    </branch>
> +  </autotools>

The idea of the minimal jhbuild moduleset is to use the version of the system is if is new enough.
To achieve that we declare how to build the minimum version needed of the library, and in this case the minimum version is ICU 61 and not 63.
Also we need a <pkg-config> entry to tell jhbuild to look for the .pc file and use the system version if is new enough.
Please consider this version of patch: http://sprunge.us/iyZbDk (it works for me to fix the build)
Comment 4 Diego Pino 2021-08-27 16:59:02 PDT
Created attachment 436693 [details]
Patch
Comment 5 EWS 2021-08-29 22:01:27 PDT
Committed r281752 (241094@main): <https://commits.webkit.org/241094@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 436693 [details].
Comment 6 Radar WebKit Bug Importer 2021-08-29 22:02:20 PDT
<rdar://problem/82509895>