Bug 229607 – [GTK][WPE] Add ICU 63.1 to JHBuild minimal dependencies

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Diego Pino]

[GTK][WPE] Add ICU 63.1 to JHBuild minimal dependencies

[Diego Pino]

Created attachment 436620 [details]
Patch

[Diego Pino]

r281375 introduced a function available only in ICU 61. Ubuntu 18.04 uses ICU systems libraries, which is version 60. Thus, compilation of WebKitGTK and WPE in Ubuntu 18.04 has been failing since then.

After discussing this with other WebKitGTK/WPE maintainers we think the best solution is to add ICU v63.1 to the list of minimal dependencies.

[Carlos Alberto Lopez Perez]

Comment on attachment 436620 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=436620&action=review

> Tools/jhbuild/jhbuild-minimal.modules:96
> +  <autotools id="icu"
> +             autogen-sh="./source/configure"
> +             autogenargs="--disable-samples --enable-weak-threads">
> +    <branch module="icu4c-63_1-src.tgz" version="63.1" checkoutdir="icu"
> +            repo="webkitgtk-jhbuild-mirror"
> +            hash="sha256:05c490b69454fce5860b7e8e2821231674af0a11d7ef2febea9a32512998cb9d">
> +      <patch file="icudata-stdlibs.patch" strip="1"/>
> +    </branch>
> +  </autotools>

The idea of the minimal jhbuild moduleset is to use the version of the system is if is new enough.
To achieve that we declare how to build the minimum version needed of the library, and in this case the minimum version is ICU 61 and not 63.
Also we need a <pkg-config> entry to tell jhbuild to look for the .pc file and use the system version if is new enough.
Please consider this version of patch: http://sprunge.us/iyZbDk (it works for me to fix the build)

[Diego Pino]

Created attachment 436693 [details]
Patch

[EWS]

Committed r281752 (241094@main): <https://commits.webkit.org/241094@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 436693 [details].

[Radar WebKit Bug Importer]

<rdar://problem/82509895>