WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
229577
[EWS] find-modified-layout-tests step should include .svg tests
https://bugs.webkit.org/show_bug.cgi?id=229577
Summary
[EWS] find-modified-layout-tests step should include .svg tests
Ryan Haddad
Reported
2021-08-26 10:58:02 PDT
[EWS] find-modified-layout-tests step should include .svg tests
Attachments
Add attachment
proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1
2021-08-26 10:58:59 PDT
I think the right logic is to re-run any tests whose: 1. test changed 2. expectation changed 3. change in TestExpectations (removed/added/changed lines)
Alexey Proskuryakov
Comment 2
2021-08-26 17:00:36 PDT
It would also be relevant to run tests whose subresources changed, but that's hard.
Alexey Proskuryakov
Comment 3
2021-08-26 17:00:56 PDT
But let's just track .svg in this bug.
Wenson Hsieh
Comment 4
2021-08-26 18:16:47 PDT
(In reply to Alexey Proskuryakov from
comment #2
)
> It would also be relevant to run tests whose subresources changed, but > that's hard.
Would this include script? (I imagine that stress-testing all layout tests that import "resources/js-test.js" when adjusting that script could be a bit excessive, for instance).
Radar WebKit Bug Importer
Comment 5
2021-09-02 10:58:17 PDT
<
rdar://problem/82683414
>
Brianna Fan
Comment 6
2024-04-23 16:40:48 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/27663
EWS
Comment 7
2024-04-25 15:39:28 PDT
Committed
278009@main
(5d452549f3c4): <
https://commits.webkit.org/278009@main
> Reviewed commits have been landed. Closing PR #27663 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug