Bug 229577 - [EWS] find-modified-layout-tests step should include .svg tests
Summary: [EWS] find-modified-layout-tests step should include .svg tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-08-26 10:58 PDT by Ryan Haddad
Modified: 2024-04-25 15:39 PDT (History)
6 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2021-08-26 10:58:02 PDT 
[EWS] find-modified-layout-tests step should include .svg tests
Comment 1 Simon Fraser (smfr) 2021-08-26 10:58:59 PDT 
I think the right logic is to re-run any tests whose:
1. test changed
2. expectation changed
3. change in TestExpectations (removed/added/changed lines)
Comment 2 Alexey Proskuryakov 2021-08-26 17:00:36 PDT 
It would also be relevant to run tests whose subresources changed, but that's hard.
Comment 3 Alexey Proskuryakov 2021-08-26 17:00:56 PDT 
But let's just track .svg in this bug.
Comment 4 Wenson Hsieh 2021-08-26 18:16:47 PDT 
(In reply to Alexey Proskuryakov from comment #2)
> It would also be relevant to run tests whose subresources changed, but
> that's hard.

Would this include script? (I imagine that stress-testing all layout tests that import "resources/js-test.js" when adjusting that script could be a bit excessive, for instance).
Comment 5 Radar WebKit Bug Importer 2021-09-02 10:58:17 PDT 
<rdar://problem/82683414>
Comment 6 Brianna Fan 2024-04-23 16:40:48 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/27663
Comment 7 EWS 2024-04-25 15:39:28 PDT 
Committed 278009@main (5d452549f3c4): <https://commits.webkit.org/278009@main>

Reviewed commits have been landed. Closing PR #27663 and removing active labels.