WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
22957
RenderPath clean-up for strokeContains
https://bugs.webkit.org/show_bug.cgi?id=22957
Summary
RenderPath clean-up for strokeContains
Dirk Schulze
Reported
2008-12-21 22:54:54 PST
Move the rest of the RenderPath*.cpp code out of svg to RenderPath and Path.
Attachments
Move strokeContains back to RenderPath.cpp
(27.61 KB, patch)
2008-12-22 03:52 PST
,
Dirk Schulze
darin
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Dirk Schulze
Comment 1
2008-12-22 03:52:41 PST
Created
attachment 26199
[details]
Move strokeContains back to RenderPath.cpp This patch moves the functionality of strokeContains to RenderPath.cpp, Path and cleares many unneeded parts like CgSupport and platform dependent code like RenderPath*.cpp
Darin Adler
Comment 2
2008-12-23 08:44:37 PST
Comment on
attachment 26199
[details]
Move strokeContains back to RenderPath.cpp
> + bool strokeContains(StrokeStyleApplier* applier, const FloatPoint&) const;
Our style is to omit the argument name when the type makes it clear. Hence, no "applier" needed here.
> FloatRect strokeBoundingRect(StrokeStyleApplier* applier = 0);
Same here (not changed in this patch). r=me
Dirk Schulze
Comment 3
2009-01-21 23:57:08 PST
landed in
r39805
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug