Bug 22957 - RenderPath clean-up for strokeContains
Summary: RenderPath clean-up for strokeContains
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2008-12-21 22:54 PST by Dirk Schulze
Modified: 2009-01-21 23:57 PST (History)
0 users

See Also:

Move strokeContains back to RenderPath.cpp (27.61 KB, patch)
2008-12-22 03:52 PST, Dirk Schulze
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Schulze 2008-12-21 22:54:54 PST
Move the rest of the RenderPath*.cpp code out of svg to RenderPath and Path.
Comment 1 Dirk Schulze 2008-12-22 03:52:41 PST
Created attachment 26199 [details]
Move strokeContains back to RenderPath.cpp

This patch moves the functionality of strokeContains to RenderPath.cpp, Path and cleares many unneeded parts like CgSupport and platform dependent code like RenderPath*.cpp
Comment 2 Darin Adler 2008-12-23 08:44:37 PST
Comment on attachment 26199 [details]
Move strokeContains back to RenderPath.cpp

> +        bool strokeContains(StrokeStyleApplier* applier, const FloatPoint&) const;

Our style is to omit the argument name when the type makes it clear. Hence, no "applier" needed here.

>          FloatRect strokeBoundingRect(StrokeStyleApplier* applier = 0);

Same here (not changed in this patch).

Comment 3 Dirk Schulze 2009-01-21 23:57:08 PST
landed in r39805.