Implement initial support
Created attachment 436483 [details]
Created attachment 436491 [details]
Comment on attachment 436491 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=436491&action=review
> + Variant<CascadeLayerName, Vector<CascadeLayerName>> m_nameVariant;
Is this preferable to just always using a Vector<>? Or is a name list with one item different from a simple name?
> Namespace = 10,
What happened to 9? Why do we number these from here on?
> + CSSAtRuleLayer = 13,
Not sure why we need exploit values here?
> + // FIXME: This is not correct when adding a sublayer to an already registered layer after it has gained siblings.
Reference a bug url?
> + // FIXME: These should be in stack.
in a stack? on the stack?
> Is this preferable to just always using a Vector<>? Or is a name list with
> one item different from a simple name?
One for the statement case, another for the block case. See the different constructor variants. I just used Vector initially but this ended up reading better. Otherwise I also need a separate bool to differentiate between the cases.
> What happened to 9? Why do we number these from here on?
Needs some historical digging.
> Not sure why we need exploit values here?
We don't, I was just sticking with the existing style.
> Reference a bug url?
> in a stack? on the stack?
I'll be fixing both shortly.
Committed r281701 (241051@main): <https://commits.webkit.org/241051@main>
All reviewed patches have been landed. Closing bug and clearing flags on attachment 436491 [details].