RESOLVED CONFIGURATION CHANGED 22954
CSSFontFaceSrcValue::cssText() and SVGPaint::cssText() need proper url() quoting
https://bugs.webkit.org/show_bug.cgi?id=22954
Summary CSSFontFaceSrcValue::cssText() and SVGPaint::cssText() need proper url() quoting
David Kilzer (:ddkilzer)
Reported 2008-12-21 14:59:28 PST
* SUMMARY The CSSFontFaceSrcValue::cssText() and SVGPaint::cssText() methods do not quote url() values that they return like CSSPrimitiveValue::cssText() does. The code in CSSPrimitiveValue.cpp needs to be moved to CSSHelper.cpp (or similar) so that it may be shared amongst other classes. All ::cssText() methods should probably be checked to see if they need quoteString(), quoteStringIfNeeded() or quoteURLIfNeeded().
Attachments
Ahmad Saleem
Comment 1 2022-07-13 00:54:08 PDT
I think this has been done as part of following commit: https://github.com/WebKit/WebKit/commit/57225069d1dfab7bc8837260d4c1988af4e8d8d1 While I am not able to find SVGPaint in following - https://github.com/WebKit/WebKit/tree/main/Source/WebCore/svg I think it was moved to CSSValue (if I am not mistaken) https://github.com/WebKit/WebKit/commit/2eeb47ef98914cf782255e9566718443b5b2f26e#diff-e12b734fe184c4e6ec774c101408a4e06d8ba8a80b6815f555aa2ca52c6bb71e I think this can be closed - if it is now fixed (no clear on SVGPaint part). Thanks!
Ryosuke Niwa
Comment 2 2022-07-13 13:22:23 PDT
Sounds like this has been fixed then.
Note You need to log in before you can comment on or make changes to this bug.