Bug 229500 - Remove some iOS-specific compile-time guards that are no longer needed
Summary: Remove some iOS-specific compile-time guards that are no longer needed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-08-25 10:15 PDT by Wenson Hsieh
Modified: 2021-08-25 21:02 PDT (History)
11 users (show)

See Also:


Attachments
Patch (37.37 KB, patch)
2021-08-25 13:12 PDT, Wenson Hsieh
no flags Details | Formatted Diff | Diff
For landing (35.86 KB, patch)
2021-08-25 13:54 PDT, Wenson Hsieh
ews-feeder: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2021-08-25 10:15:59 PDT
.
Comment 1 Wenson Hsieh 2021-08-25 13:12:13 PDT
Created attachment 436411 [details]
Patch
Comment 2 Wenson Hsieh 2021-08-25 13:49:29 PDT
Comment on attachment 436411 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=436411&action=review

Thanks for the review!

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:9942
> +    NSLog(@"<WK>: Setting visual search preview bounds: %@", NSStringFromCGRect(_visualSearchPreviewImageBounds));

Whoops, it looks like an artifact of my next WIP patch bled into this :P.

Will remove before landing.

> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:-2791
> -    if (!renderer.document().frame()->isMainFrame()) {
> -        FrameView *view = renderer.document().frame()->view();
> +    if (RefPtr view = renderer.document().frame()->view())
>          info.bounds = view->contentsToRootView(info.bounds);
> -    }

(Ditto, will remove this).
Comment 3 Wenson Hsieh 2021-08-25 13:54:31 PDT
Created attachment 436421 [details]
For landing
Comment 4 EWS 2021-08-25 18:38:32 PDT
Committed r281610 (240966@main): <https://commits.webkit.org/240966@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 436421 [details].
Comment 5 Radar WebKit Bug Importer 2021-08-25 18:39:28 PDT
<rdar://problem/82368477>