Bug 229497 – [GStreamer] Track handling refactoring

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Philippe Normand]

Let's try to re-land the changes initially reviewed in bug 229123.

[Philippe Normand]

Created attachment 436392 [details]
Patch

[EWS]

Committed r281741 (241083@main): <https://commits.webkit.org/241083@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 436392 [details].

[Radar WebKit Bug Importer]

<rdar://problem/82490003>

[Arcady Goldmints-Orlov]

It appears that this has made the test media/track/in-band/track-in-band-kate-ogg-cues-added-once.html considerably more likely to fail (though admittedly it was somewhat flaky even before this change).

When it fails it does so like this:

--- /home/buildbot/worker/gtk-linux-64-release-tests/build/layout-test-results/media/track/in-band/track-in-band-kate-ogg-cues-added-once-expected.txt
+++ /home/buildbot/worker/gtk-linux-64-release-tests/build/layout-test-results/media/track/in-band/track-in-band-kate-ogg-cues-added-once-actual.txt
@@ -6,13 +6,13 @@
 ** Setting track 1 to showing
 RUN(inbandTrack1.mode = 'showing')
 RUN(video.play())
-EXPECTED (inbandTrack1.cues.length > '0') OK
+EXPECTED (inbandTrack1.cues.length > '0'), OBSERVED '0' FAIL
 RUN(video.pause())
 RUN(video.currentTime = 0)
 RUN(video.play())
 
 EVENT(seeked)
-EXPECTED (inbandTrack1.cues.length > '0') OK
+EXPECTED (inbandTrack1.cues.length > '0'), OBSERVED '0' FAIL
 RUN(video.pause())
 Test all cues are equal OK
 END OF TEST

[Philippe Normand]

Indeed... I'll pile this somewhere on the ever-to-big TODO :(