Bug 229489 – Web Share tests are out of date

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Marcos Caceres]

Web Share tests from WPT are a bit out of date and could use an update.

[Marcos Caceres]

Created attachment 436380 [details]
Patch

[EWS Watchlist]

This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess

[Marcos Caceres]

@thorton, note there seems to be a bug in URL::isValid (which I guess might mean a bug in the URLParser)... In particular, the URL "http://a.b:65536" should be treated marked as invalid.

[Tim Horton]

Ccing Alex for that bit (but probably best to file a bug about it)

[Marcos Caceres]

(In reply to Tim Horton from comment #4)
> Ccing Alex for that bit (but probably best to file a bug about it)

Filed https://bugs.webkit.org/show_bug.cgi?id=229490

[Radar WebKit Bug Importer]

<rdar://problem/82617175>

[Marcos Caceres]

Created attachment 437227 [details]
Patch

[Marcos Caceres]

Updated the changelog to reflect reviewer. I'll need someone to cq+ this form me if it looks ok, as I don't have committer privileges.

[Tim Horton]

(In reply to Marcos Caceres from comment #8)
> Updated the changelog to reflect reviewer. I'll need someone to cq+ this
> form me if it looks ok, as I don't have committer privileges.

You don't have to update the reviewer manually, the cq will do it (also, set cq? if you want cq :D). But let's try it!

[Marcos Caceres]

(In reply to Tim Horton from comment #9) 
> You don't have to update the reviewer manually, the cq will do it (also, set
> cq? if you want cq :D). But let's try it!

Thanks, Tim! Sorry, I'm still new to the process of contributing 🐣

[EWS]

Committed r281973 (241280@main): <https://commits.webkit.org/241280@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 437227 [details].

[Aakash Jain]

(In reply to EWS from comment #11)
> All reviewed patches have been landed. Closing bug and clearing flags on attachment 437227 [details].
This seems to have broken these two tests on ios-wk2 (EWS indicated that failure on previous version of this patch). Please wait for EWS to finish and be green before landing/cq+ing patches.

- imported/w3c/web-platform-tests/web-share/canShare.https.html

History: https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fweb-share%2FcanShare.https.html

- imported/w3c/web-platform-tests/web-share/share-empty.https.html
History: https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fweb-share%2Fshare-empty.https.html

[WebKit Commit Bot]

Re-opened since this is blocked by bug 229861

[Marcos Caceres]

Created attachment 438641 [details]
Patch

[EWS]

Committed r282745 (241882@main): <https://commits.webkit.org/241882@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 438641 [details].