Bug 229484 - ImageBitmap::create(ScriptExecutionContext&, const IntSize&) is unused
Summary: ImageBitmap::create(ScriptExecutionContext&, const IntSize&) is unused
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Cameron McCormack (:heycam)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-08-24 17:58 PDT by Cameron McCormack (:heycam)
Modified: 2021-08-24 18:11 PDT (History)
9 users (show)

See Also:

Attachments
Patch (2.02 KB, patch)
2021-08-24 18:00 PDT, Cameron McCormack (:heycam) 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Cameron McCormack (:heycam) 2021-08-24 17:58:45 PDT 
.
Comment 1 Radar WebKit Bug Importer 2021-08-24 17:59:13 PDT 
<rdar://problem/82318976>
Comment 2 Cameron McCormack (:heycam) 2021-08-24 18:00:30 PDT 
Created attachment 436356 [details]
Patch
Comment 3 Simon Fraser (smfr) 2021-08-24 18:02:38 PDT 
Comment on attachment 436356 [details]
Patch

Wasn't this for ImageBitmap creation in workers?
Comment 4 Cameron McCormack (:heycam) 2021-08-24 18:05:45 PDT 
(In reply to Simon Fraser (smfr) from comment #3)
> Comment on attachment 436356 [details]
> Patch
> 
> Wasn't this for ImageBitmap creation in workers?

When it was originally added, OffscreenCanvas::transferToImageBitmap used it.  But now that uses the other one (which takes an ImageBitmapBacking).
Comment 5 Cameron McCormack (:heycam) 2021-08-24 18:09:26 PDT 
Ah no I'm wrong, there's another current caller to it below in that same function.  (Why did that not cause a build failure for me locally?)
Comment 6 Cameron McCormack (:heycam) 2021-08-24 18:10:56 PDT 
Comment on attachment 436356 [details]
Patch

Sorry for the noise.