Bug 229480 - removeFromTopLayer shouldn't be called in every removal of an element
Summary: removeFromTopLayer shouldn't be called in every removal of an element
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks: 229488
  Show dependency tree / graph
 
Reported: 2021-08-24 17:07 PDT by Ryosuke Niwa
Modified: 2021-08-25 00:59 PDT (History)
9 users (show)

See Also:

Attachments
Move the call to HTMLDialogElement (2.91 KB, patch)
2021-08-24 17:09 PDT, Ryosuke Niwa 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Move the call to HTMLDialogElement (2.90 KB, patch)
2021-08-24 17:21 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2021-08-24 17:07:39 PDT 
removeFromTopLayer shouldn't be called in every removal of an element
Comment 1 Ryosuke Niwa 2021-08-24 17:09:39 PDT 
Created attachment 436350 [details]
Move the call to HTMLDialogElement
Comment 2 Ryosuke Niwa 2021-08-24 17:21:52 PDT 
Created attachment 436351 [details]
Move the call to HTMLDialogElement
Comment 3 Simon Fraser (smfr) 2021-08-24 17:31:14 PDT 
Comment on attachment 436351 [details]
Move the call to HTMLDialogElement

View in context: https://bugs.webkit.org/attachment.cgi?id=436351&action=review

> Source/WebCore/ChangeLog:9
> +        the only place where top layer is currenlty used.

"currenlty"
Comment 4 Ryosuke Niwa 2021-08-24 17:48:53 PDT 
(In reply to Simon Fraser (smfr) from comment #3)
> Comment on attachment 436351 [details]
> Move the call to HTMLDialogElement
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=436351&action=review
> 
> > Source/WebCore/ChangeLog:9
> > +        the only place where top layer is currenlty used.
> 
> "currenlty"

Fixed. Thanks.
Comment 5 Ryosuke Niwa 2021-08-24 23:07:06 PDT 
Comment on attachment 436351 [details]
Move the call to HTMLDialogElement

Clearing flags on attachment: 436351

Committed r281548 (240915@main): <https://commits.webkit.org/240915@main>
Comment 6 Ryosuke Niwa 2021-08-24 23:07:09 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2021-08-24 23:08:17 PDT 
<rdar://problem/82326535>