Bug 229466 – Update availability macros for APIs available in iOS 14.5 and macOS 11.3

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Alex Christensen]

Update availability macros for APIs available in iOS 14.5 and macOS 11.3

[Alex Christensen]

Created attachment 436326 [details]
Patch

[Chris Dumez]

Comment on attachment 436326 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=436326&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebView.h:533
> +@property (nonatomic, nullable, copy) id interactionState WK_API_AVAILABLE(macos(11.3), ios(14.5));

How did you determine those? For example, this particular API was added in rdar://70956146 which says iOS 15. Are we sure it went into iOS 14.5? (not sure about the other APIs).

[Alex Christensen]

I am sure about the download related APIs and the HTTPS upgrade API.  The rest are based on the the diff Brent sent me, which I could be interpreting incorrectly.

[Chris Dumez]

Comment on attachment 436326 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=436326&action=review

>> Source/WebKit/UIProcess/API/Cocoa/WKWebView.h:533
>> +@property (nonatomic, nullable, copy) id interactionState WK_API_AVAILABLE(macos(11.3), ios(14.5));
> 
> How did you determine those? For example, this particular API was added in rdar://70956146 which says iOS 15. Are we sure it went into iOS 14.5? (not sure about the other APIs).

This was not in iOS 11.3: https://trac.webkit.org/browser/webkit/branches/safari-611.1.21.0-branch/Source/WebKit/UIProcess/API/Cocoa/WKWebView.h

Other APIs updated in this patch are potentially incorrect too given they are based on the same diff.

[Chris Dumez]

(In reply to Chris Dumez from comment #4)
> Comment on attachment 436326 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=436326&action=review
> 
> >> Source/WebKit/UIProcess/API/Cocoa/WKWebView.h:533
> >> +@property (nonatomic, nullable, copy) id interactionState WK_API_AVAILABLE(macos(11.3), ios(14.5));
> > 
> > How did you determine those? For example, this particular API was added in rdar://70956146 which says iOS 15. Are we sure it went into iOS 14.5? (not sure about the other APIs).
> 
> This was not in iOS 11.3:

I meant iOS 14.5 :/

> https://trac.webkit.org/browser/webkit/branches/safari-611.1.21.0-branch/
> Source/WebKit/UIProcess/API/Cocoa/WKWebView.h
> 
> Other APIs updated in this patch are potentially incorrect too given they
> are based on the same diff.

[Alex Christensen]

Created attachment 436329 [details]
Patch

[Chris Dumez]

Comment on attachment 436329 [details]
Patch

r=me

[EWS]

Found 1 new test failure: imported/w3c/web-platform-tests/IndexedDB/serialize-sharedarraybuffer-throws.https.html

[Radar WebKit Bug Importer]

<rdar://problem/82317642>

[EWS]

Committed r281780 (241117@main): <https://commits.webkit.org/241117@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 436329 [details].