Bug 22946 - [Patch] QWebPage/QWebView::selectAll to select all content
Summary: [Patch] QWebPage/QWebView::selectAll to select all content
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Enhancement
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 50049
  Show dependency tree / graph
 
Reported: 2008-12-20 03:43 PST by Urs Wolfer
Modified: 2011-01-05 05:06 PST (History)
1 user (show)

See Also:

Attachments
Patch to add QWebPage/QWebView::selectAll (2.50 KB, patch)
2008-12-20 03:47 PST, Urs Wolfer 		hausmann: review-
Details | Formatted Diff | Diff
Updated patch as suggested by Simon (1.46 KB, patch)
2009-01-25 08:19 PST, Urs Wolfer 		no flags Details | Formatted Diff | Diff
Updated as discussed with Simon on IRC (1.92 KB, patch)
2009-01-25 09:17 PST, Urs Wolfer 		hausmann: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Urs Wolfer 2008-12-20 03:43:07 PST 
The attached patch adds functions to select all content of a QWebPage. There is also a helper function in QWebView to select the content. API docs added as well (assuming it will go into Qt 4.6; though I see no problems to add it to 4.5 since the changes are really straight forward.)
Comment 1 Urs Wolfer 2008-12-20 03:47:52 PST 
Created attachment 26167 [details]
Patch to add QWebPage/QWebView::selectAll
Comment 2 Simon Hausmann 2009-01-25 07:03:31 PST 
Comment on attachment 26167 [details]
Patch to add QWebPage/QWebView::selectAll

I agree that the change is straight forward, and it looks correct. But I think this should be a function of QWebFrame only, not QWebPage or QWebView, because the selection is a property of a frame. In a HTML frameset with many frames each frame has its own selection.
Comment 3 Urs Wolfer 2009-01-25 08:19:49 PST 
Created attachment 27018 [details]
Updated patch as suggested by Simon
Comment 4 Urs Wolfer 2009-01-25 09:17:14 PST 
Created attachment 27020 [details]
Updated as discussed with Simon on IRC
Comment 5 Simon Hausmann 2009-01-25 09:28:42 PST 
Comment on attachment 27020 [details]
Updated as discussed with Simon on IRC

r=me
Comment 6 Simon Hausmann 2009-01-25 09:29:33 PST 
Landed in r40228