Bug 229453 - [Monterey] LayoutTest media/element-containing-pip-video-going-into-fullscreen.html is flaky timeout/crash
Summary: [Monterey] LayoutTest media/element-containing-pip-video-going-into-fullscree...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: Other
Hardware: Unspecified macOS 11
: P2 Normal
Assignee: Peng Liu
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-08-24 10:27 PDT by Peng Liu
Modified: 2021-08-25 15:46 PDT (History)
12 users (show)

See Also:


Attachments
Patch (7.62 KB, patch)
2021-08-24 10:40 PDT, Peng Liu
eric.carlson: review+
Details | Formatted Diff | Diff
Revise the patch based on Eric's comment (7.67 KB, patch)
2021-08-24 11:31 PDT, Peng Liu
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Peng Liu 2021-08-24 10:27:18 PDT
ASSERTION FAILED: standby || mode != HTMLMediaElementEnums::VideoFullscreenModeNone
/Volumes/Data/worker/trunk-star-debug-archive/build/OpenSource/Source/WebKit/WebProcess/cocoa/VideoFullscreenManager.mm(252) : void WebKit::VideoFullscreenManager::enterVideoFullscreenForVideoElement(WebCore::HTMLVideoElement &, HTMLMediaElementEnums::VideoFullscreenMode, bool)
1   0x40f3b5e79 WTFCrash
2   0x3ee73aa9b WTFCrashWithInfo(int, char const*, char const*, int)
3   0x3f01e4224 WebKit::VideoFullscreenManager::enterVideoFullscreenForVideoElement(WebCore::HTMLVideoElement&, unsigned int, bool)
4   0x3f0228e69 WebKit::VideoFullscreenManager::didCleanupFullscreen(WTF::ObjectIdentifier<WebKit::PlaybackSessionContextIdentifierType>)::$_18::operator()() const
5   0x3f0228d29 WTF::Detail::CallableWrapper<WebKit::VideoFullscreenManager::didCleanupFullscreen(WTF::ObjectIdentifier<WebKit::PlaybackSessionContextIdentifierType>)::$_18, void>::call()
6   0x40f3ded42 WTF::Function<void ()>::operator()() const
7   0x40f45a81e WTF::RunLoop::performWork()
8   0x40f45e0fe WTF::RunLoop::performWork(void*)
9   0x7ff8011f3d4a __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__
10  0x7ff8011f3cb2 __CFRunLoopDoSource0
11  0x7ff8011f3a27 __CFRunLoopDoSources0
12  0x7ff8011f2447 __CFRunLoopRun
13  0x7ff8011f1a09 CFRunLoopRunSpecific
14  0x7ff80204d437 -[NSRunLoop(NSRunLoop) runMode:beforeDate:]
15  0x7ff8020d7b13 -[NSRunLoop(NSRunLoop) run]
16  0x7ff800e84377 _xpc_objc_main
17  0x7ff800e83cfa xpc_main
18  0x3ef54e56f WebKit::XPCServiceMain(int, char const**)
19  0x3f0be007b WKXPCServiceMain
20  0x10190cea2 main
21  0x10a4b44d5
com.apple.WebKit.WebContent.Development terminated (pid 46200) because the process crashed
Comment 1 Peng Liu 2021-08-24 10:27:59 PDT
<rdar://80346428>
Comment 2 Peng Liu 2021-08-24 10:40:54 PDT
Created attachment 436306 [details]
Patch
Comment 3 Eric Carlson 2021-08-24 11:21:13 PDT
Comment on attachment 436306 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=436306&action=review

> Source/WebKit/ChangeLog:16
> +        This change fixes an assertion failure in `enterVideoFullscreenForVideoElement()`.

This requires the reader to look at the code before and after the change. Instead I think it would be better to say something like "Return immediately if the element is not in fullscreen to avoid an assertion later in `enterVideoFullscreenForVideoElement`".
Comment 4 Peng Liu 2021-08-24 11:31:00 PDT
Created attachment 436312 [details]
Revise the patch based on Eric's comment
Comment 5 Peng Liu 2021-08-24 11:31:55 PDT
Comment on attachment 436306 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=436306&action=review

>> Source/WebKit/ChangeLog:16
>> +        This change fixes an assertion failure in `enterVideoFullscreenForVideoElement()`.
> 
> This requires the reader to look at the code before and after the change. Instead I think it would be better to say something like "Return immediately if the element is not in fullscreen to avoid an assertion later in `enterVideoFullscreenForVideoElement`".

Agree! Fixed.
Comment 6 Peng Liu 2021-08-25 09:13:48 PDT
The layout test failure on mac-debug-wk1 bot is not relevant to this patch.
Comment 7 EWS 2021-08-25 09:41:30 PDT
Committed r281557 (240924@main): <https://commits.webkit.org/240924@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 436312 [details].
Comment 8 Alexey Proskuryakov 2021-08-25 15:46:16 PDT
Comment on attachment 436312 [details]
Revise the patch based on Eric's comment

View in context: https://bugs.webkit.org/attachment.cgi?id=436312&action=review

> LayoutTests/platform/mac-wk2/TestExpectations:691
> +[ Catalina BigSur Monterey ] media/element-containing-pip-video-going-into-fullscreen.html [ Pass ]

"Catalina BigSur Monterey" is all of them, so we don't need the OS version qualifiers. In fact, they are harmful, as they result in the test being skipped on all future versions.