Add a new experimental feature flag to support development of a link sanitizer for private browsing mode.
<rdar://problem/82298037>
Created attachment 436313 [details] Patch
Comment on attachment 436313 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=436313&action=review > Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml:643 > + humanReadableName: "Link Sanitizer enabled" I think this should just be "Link sanitizer"... > Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml:644 > + humanReadableDescription: "Sanitize the links" ...then this should be "Enable link sanitizer" to better align with other examples in this file. > Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml:647 > + default: true r- because this feature should be off by default, so default values should be false.
Comment on attachment 436313 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=436313&action=review >> Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml:644 >> + humanReadableDescription: "Sanitize the links" > > ...then this should be "Enable link sanitizer" to better align with other examples in this file. Onto these. >> Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml:647 >> + default: true > > r- because this feature should be off by default, so default values should be false. Do we set false for only WebKitLegacy, or for WebKitLegacy, Webkit and WebCore?
Comment on attachment 436313 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=436313&action=review >>> Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml:647 >>> + default: true >> >> r- because this feature should be off by default, so default values should be false. > > Do we set false for only WebKitLegacy, or for WebKitLegacy, Webkit and WebCore? Set all of them to 'false'.
Created attachment 436409 [details] Patch
Committed r281630 (240986@main): <https://commits.webkit.org/240986@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 436409 [details].