Bug 229439 - ANGLE Metal infinities and NaNs generated with incorrect syntax
Summary: ANGLE Metal infinities and NaNs generated with incorrect syntax
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: ANGLE (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kimmo Kinnunen
URL:
Keywords: InRadar
: 229508 (view as bug list)
Depends on:
Blocks:
 
Reported: 2021-08-24 02:47 PDT by Kimmo Kinnunen
Modified: 2021-08-30 11:13 PDT (History)
8 users (show)

See Also:

Attachments
Patch (22.29 KB, patch)
2021-08-24 03:10 PDT, Kimmo Kinnunen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kimmo Kinnunen 2021-08-24 02:47:39 PDT 
ANGLE Metal infinities and NaNs generated with incorrect syntax
0./0. -> NANnanf
1./0. -> inff
Comment 1 Kimmo Kinnunen 2021-08-24 02:48:39 PDT 
<rdar://81033366>
Comment 2 Kimmo Kinnunen 2021-08-24 03:10:42 PDT 
Created attachment 436272 [details]
Patch
Comment 3 EWS Watchlist 2021-08-24 03:11:55 PDT 
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Comment 4 Kimmo Kinnunen 2021-08-24 03:14:12 PDT 
Actually, just NANs are incorrect. For ToT, infs were ok since bug 226953 which caused this regression.
Comment 5 Kenneth Russell 2021-08-24 13:45:55 PDT 
+Gregg Tavares as FYI, who's been rediscovering some of these during the upstreaming process.
Comment 6 EWS 2021-08-24 23:04:33 PDT 
Committed r281547 (240914@main): <https://commits.webkit.org/240914@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 436272 [details].
Comment 7 Kimmo Kinnunen 2021-08-30 11:13:10 PDT 
*** Bug 229508 has been marked as a duplicate of this bug. ***